Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/udfclient-0.8.11/cd_disect.c Examining data/udfclient-0.8.11/cd_sessions.c Examining data/udfclient-0.8.11/config.h Examining data/udfclient-0.8.11/defs.h Examining data/udfclient-0.8.11/dirhash.h Examining data/udfclient-0.8.11/ecma167-udf.h Examining data/udfclient-0.8.11/hash.h Examining data/udfclient-0.8.11/mmc_format.c Examining data/udfclient-0.8.11/newfs_udf.c Examining data/udfclient-0.8.11/osta.c Examining data/udfclient-0.8.11/osta.h Examining data/udfclient-0.8.11/queue.h Examining data/udfclient-0.8.11/udf.c Examining data/udfclient-0.8.11/udf.h Examining data/udfclient-0.8.11/udf_allocentries.c Examining data/udfclient-0.8.11/udf_bmap.c Examining data/udfclient-0.8.11/udf_bswap.h Examining data/udfclient-0.8.11/udf_discop.c Examining data/udfclient-0.8.11/udf_discop.h Examining data/udfclient-0.8.11/udf_readwrite.c Examining data/udfclient-0.8.11/udf_unix.c Examining data/udfclient-0.8.11/udf_unix.h Examining data/udfclient-0.8.11/udf_verbose.c Examining data/udfclient-0.8.11/udfclient.c Examining data/udfclient-0.8.11/udfdump.c Examining data/udfclient-0.8.11/uio.c Examining data/udfclient-0.8.11/uio.h Examining data/udfclient-0.8.11/uscsi_sense.c Examining data/udfclient-0.8.11/uscsi_subr.c Examining data/udfclient-0.8.11/uscsilib.h Examining data/udfclient-0.8.11/uscsilib_machdep.h Examining data/udfclient-0.8.11/vfs_dirhash.c FINAL RESULTS: data/udfclient-0.8.11/udfclient.c:602:12: [5] (race) chown: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchown( ) instead. notok = chown(fulldstname, stat.st_uid, stat.st_gid); data/udfclient-0.8.11/newfs_udf.c:636:3: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. sprintf(volset_name, "%0"PRIx64, volset_nr); data/udfclient-0.8.11/udf.c:165:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(result, name + 1); data/udfclient-0.8.11/udf.c:4784:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy((char *) regid->id, APP_NAME); data/udfclient-0.8.11/udf.c:4793:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy((char *) regid->id, IMPL_NAME); data/udfclient-0.8.11/udf.c:4812:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy((char *) regid->id, name); data/udfclient-0.8.11/udf.c:4831:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy((char *) regid->id, content_id); data/udfclient-0.8.11/udf.c:5152:6: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. if (sscanf(pos, "-%u%n%s", &high, &len, nop) >= 1) { data/udfclient-0.8.11/udf.c:5159:7: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. if (sscanf(pos, "%u%n%s", &low, &len, nop) >= 1) { data/udfclient-0.8.11/udf.c:5169:9: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. if (sscanf(pos, "%u%n%s", &high, &len, nop) >= 1) { data/udfclient-0.8.11/udf_verbose.c:788:8: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(what, "\t\t\t\t%s created at ", type_txt); data/udfclient-0.8.11/udf_verbose.c:791:8: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(what, "\t\t\t\t%s last modified at ", type_txt); data/udfclient-0.8.11/udf_verbose.c:794:8: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(what, "\t\t\t\t%s may be deleted after ", type_txt); data/udfclient-0.8.11/udf_verbose.c:797:8: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(what, "\t\t\t\t%s may only be used after ", type_txt); data/udfclient-0.8.11/udf_verbose.c:800:8: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(what, "\t\t\t\t%s last backuped at ", type_txt); data/udfclient-0.8.11/udf_verbose.c:803:8: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(what, "\t\t\t\tUndefined meaning for %s time stamp ", type_txt); data/udfclient-0.8.11/udf_verbose.c:1376:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(fullpath, "%s/%s", prefix, dirent->d_name); data/udfclient-0.8.11/udfclient.c:116:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(entry.d_name, mountable->mount_name); data/udfclient-0.8.11/udfclient.c:234:2: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(resultpath, cur_path); data/udfclient-0.8.11/udfclient.c:241:2: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(resultpath, relpath); data/udfclient-0.8.11/udfclient.c:246:20: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). if (pos != here) strcpy(here, pos); data/udfclient-0.8.11/udfclient.c:256:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(here+1, here + 3); data/udfclient-0.8.11/udfclient.c:260:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(here+1, here + 2); data/udfclient-0.8.11/udfclient.c:264:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(here+1, here + 4); data/udfclient-0.8.11/udfclient.c:267:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(pos, here+1); data/udfclient-0.8.11/udfclient.c:272:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(here+1, here + 3); data/udfclient-0.8.11/udfclient.c:275:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(pos, here+1); data/udfclient-0.8.11/udfclient.c:555:6: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if (system("/bin/ls")) { data/udfclient-0.8.11/udfclient.c:754:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(fullsrcpath, "%s/%s", srcprefix, dirent->d_name); data/udfclient-0.8.11/udfclient.c:755:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(fulldstpath, "%s/%s", dstprefix, dirent->d_name); data/udfclient-0.8.11/udfclient.c:1023:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(fullsrcpath, "%s/%s", srcprefix, srcname); data/udfclient-0.8.11/udfclient.c:1024:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(fulldstpath, "%s/%s", dstprefix, dstname); data/udfclient-0.8.11/udfclient.c:1291:7: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(fullpath, "%s/%s", full_parent_name, dirent->d_name); data/udfclient-0.8.11/vfs_dirhash.c:59:21: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define DPRINTF(a) printf(a); data/udfclient-0.8.11/mmc_format.c:736:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((flag = getopt(argc, argv, "BFMRGSwpsc:rhHIX:Ob:D")) != -1) { data/udfclient-0.8.11/newfs_udf.c:585:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((flag = getopt(argc, argv, "S:P:L:v:m:2s:b:B:u:D")) != -1) { data/udfclient-0.8.11/newfs_udf.c:630:2: [3] (random) srandom: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srandom(time(NULL)); data/udfclient-0.8.11/newfs_udf.c:634:28: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. volset_nr = (uint64_t) random(); data/udfclient-0.8.11/newfs_udf.c:640:33: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. sprintf(privol_name, "%08lx", random()); data/udfclient-0.8.11/udfclient.c:537:35: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (strcmp(arg1, "" )==0) arg1 = getenv("HOME"); data/udfclient-0.8.11/udfclient.c:538:35: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (strcmp(arg1, "~")==0) arg1 = getenv("HOME"); data/udfclient-0.8.11/udfclient.c:1699:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((flag = getopt(argc, argv, "u:Dr:WFb:s")) != -1) { data/udfclient-0.8.11/udfdump.c:187:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((flag = getopt(argc, argv, "u:r:b:DSst")) != -1) { data/udfclient-0.8.11/cd_disect.c:130:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:169:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Reserved profile 0x%02x", profile); data/udfclient-0.8.11/cd_disect.c:186:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:200:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Unknown/reserved data block type 0x%02x", type); data/udfclient-0.8.11/cd_disect.c:206:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:210:3: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. strcat(scrap, "data track "); data/udfclient-0.8.11/cd_disect.c:211:18: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. if (cntrl & 1) strcat(scrap, "; incremental "); else strcat(scrap, "; uninterrupted"); data/udfclient-0.8.11/cd_disect.c:211:57: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. if (cntrl & 1) strcat(scrap, "; incremental "); else strcat(scrap, "; uninterrupted"); data/udfclient-0.8.11/cd_disect.c:213:3: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. strcat(scrap, "audio track"); data/udfclient-0.8.11/cd_disect.c:214:18: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. if (cntrl & 1) strcat(scrap, "; pre-emphasis of 50/15 microseconds"); else strcat(scrap, "; no pre-emphasis"); data/udfclient-0.8.11/cd_disect.c:214:78: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. if (cntrl & 1) strcat(scrap, "; pre-emphasis of 50/15 microseconds"); else strcat(scrap, "; no pre-emphasis"); data/udfclient-0.8.11/cd_disect.c:216:17: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. if (cntrl & 2) strcat(scrap, "; copy prohibited"); data/udfclient-0.8.11/cd_disect.c:223:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:230:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Unknown/reserved session format type 0x%02x", format); data/udfclient-0.8.11/cd_disect.c:237:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:244:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Unknown/reserved TOC disc type type 0x%02x", type); data/udfclient-0.8.11/cd_disect.c:250:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:270:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Unknown/reserved inactivity timeout 0x%02x", time); data/udfclient-0.8.11/cd_disect.c:276:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:298:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Unknown/reserved device type 0x%02x", type); data/udfclient-0.8.11/cd_disect.c:304:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:312:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Unknown/reserved device qualifier 0x%02x", device_qualifier); data/udfclient-0.8.11/cd_disect.c:318:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:327:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Unknown/Obsolete/reserved (0x%02x)", version); data/udfclient-0.8.11/cd_disect.c:333:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:1398:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/cd_disect.c:1416:4: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "(%d)", speed); data/udfclient-0.8.11/ecma167-udf.h:334:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char vol_id[32]; /* KEY ; main identifier of this disc */ data/udfclient-0.8.11/ecma167-udf.h:341:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char volset_id[128]; /* KEY ; if part of a multi-disc set or a band of volumes */ data/udfclient-0.8.11/ecma167-udf.h:359:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char logvol_id[128]; data/udfclient-0.8.11/ecma167-udf.h:361:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char lvinfo1[36]; data/udfclient-0.8.11/ecma167-udf.h:362:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char lvinfo2[36]; data/udfclient-0.8.11/ecma167-udf.h:363:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char lvinfo3[36]; data/udfclient-0.8.11/ecma167-udf.h:377:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char impl_use[460]; data/udfclient-0.8.11/ecma167-udf.h:387:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char logvol_id[128]; /* KEY */ data/udfclient-0.8.11/ecma167-udf.h:517:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char logvol_id[128]; /* newer version of the LVD one */ data/udfclient-0.8.11/ecma167-udf.h:633:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char logvol_id[128]; /* for recovery */ data/udfclient-0.8.11/ecma167-udf.h:635:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char fileset_id[32]; /* Mountpoint !! */ data/udfclient-0.8.11/ecma167-udf.h:636:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char copyright_file_id[32]; data/udfclient-0.8.11/ecma167-udf.h:637:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char abstract_file_id[32]; data/udfclient-0.8.11/ecma167-udf.h:735:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char logvol_id[128]; /* replaces logvol name */ data/udfclient-0.8.11/mmc_format.c:158:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/mmc_format.c:186:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Reserved profile 0x%02x", profile); data/udfclient-0.8.11/mmc_format.c:766:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). certification = atoi(optarg); data/udfclient-0.8.11/mmc_format.c:789:17: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). blockingnr = atoi(optarg); data/udfclient-0.8.11/newfs_udf.c:137:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(vrs_desc->identifier, VRS_CD001, 5); data/udfclient-0.8.11/newfs_udf.c:141:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(vrs_desc->identifier, VRS_BEA01, 5); data/udfclient-0.8.11/newfs_udf.c:146:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(vrs_desc->identifier, VRS_NSR02, 5); data/udfclient-0.8.11/newfs_udf.c:148:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(vrs_desc->identifier, VRS_NSR03, 5); data/udfclient-0.8.11/newfs_udf.c:153:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(vrs_desc->identifier, VRS_TEA01, 5); data/udfclient-0.8.11/newfs_udf.c:597:15: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). vds_num = atoi(optarg); data/udfclient-0.8.11/newfs_udf.c:600:19: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). max_vol_seq = atoi(optarg); data/udfclient-0.8.11/newfs_udf.c:606:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). alt_num_sect = atoi(optarg); data/udfclient-0.8.11/newfs_udf.c:609:23: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). alt_sector_size = atoi(optarg); data/udfclient-0.8.11/newfs_udf.c:616:19: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). udf_verbose = atoi(optarg); data/udfclient-0.8.11/newfs_udf.c:640:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(privol_name, "%08lx", random()); data/udfclient-0.8.11/newfs_udf.c:665:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fhandle = open(*argv, O_CREAT | O_TRUNC | O_RDWR, 0660); data/udfclient-0.8.11/udf.c:173:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char compound[128+128+32+32+1]; data/udfclient-0.8.11/udf.c:995:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ctime, mtime, sizeof(*ctime)); data/udfclient-0.8.11/udf.c:1303:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(next_alloc, cur_alloc, sizeof(struct udf_allocentry)); data/udfclient-0.8.11/udf.c:1369:6: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(udf_node->intern_data, pos, inf_len); data/udfclient-0.8.11/udf.c:1470:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char entry_name[NAME_MAX]; data/udfclient-0.8.11/udf.c:1817:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(pos, udf_node->intern_data, udf_node->intern_len); data/udfclient-0.8.11/udf.c:2127:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf_entry->b_data, udf_node->intern_data, udf_node->intern_len); data/udfclient-0.8.11/udf.c:2248:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(udf_node->intern_data, buf_entry->b_data, buf_entry->b_bcount); data/udfclient-0.8.11/udf.c:2478:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf_entry->b_data, udf_node->intern_data, udf_node->intern_len); data/udfclient-0.8.11/udf.c:4139:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&udf_session->anchor, avdp, sizeof(struct anchor_vdp)); data/udfclient-0.8.11/udf.c:4752:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy((char *) charspec->inf, "OSTA Compressed Unicode"); data/udfclient-0.8.11/udf.c:5511:42: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. if (fid->file_char & UDF_FILE_CHAR_PAR) strcpy(dirent->d_name, ".."); data/udfclient-0.8.11/udf.c:5942:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(fid->data + udf_rw16(fid->l_iu), i_fid->data, fid->l_fi); data/udfclient-0.8.11/udf.c:5964:42: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. if (fid->file_char & UDF_FILE_CHAR_PAR) strcpy(dirent.d_name, ".."); data/udfclient-0.8.11/udf_allocentries.c:147:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(new_entry, entry, sizeof(struct udf_allocentry)); data/udfclient-0.8.11/udf_readwrite.c:172:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, udf_session->cache_line_write + cache_diff * sector_size, sector_size); data/udfclient-0.8.11/udf_readwrite.c:186:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, udf_session->cache_line_read + cache_diff * sector_size, sector_size); data/udfclient-0.8.11/udf_readwrite.c:199:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, udf_session->cache_line_read, sector_size); data/udfclient-0.8.11/udf_readwrite.c:275:6: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(to, from, sector_size); data/udfclient-0.8.11/udf_readwrite.c:392:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(udf_session->cache_line_write + cache_diff * sector_size, source, sector_size); data/udfclient-0.8.11/udf_readwrite.c:394:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&udf_session->cache_write_callbacks[cache_diff], wrcallback, sizeof(struct udf_wrcallback)); data/udfclient-0.8.11/udf_readwrite.c:695:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(new_dscr, sector0, cur_length); data/udfclient-0.8.11/udf_verbose.c:106:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char out_buf[1024]; data/udfclient-0.8.11/udf_verbose.c:123:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char buffer[40]; data/udfclient-0.8.11/udf_verbose.c:142:7: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer, "unknown UNIX (%d)", os_id); data/udfclient-0.8.11/udf_verbose.c:153:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer, "unknown OS (%d, %d)", os_class, os_id); data/udfclient-0.8.11/udf_verbose.c:159:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[UDF_REGID_ID_SIZE+1]; data/udfclient-0.8.11/udf_verbose.c:163:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, id->id, UDF_REGID_ID_SIZE); data/udfclient-0.8.11/udf_verbose.c:568:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy((char *) chsp.inf, "OSTA Compressed Unicode"); data/udfclient-0.8.11/udf_verbose.c:691:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *type_txt, what[256]; data/udfclient-0.8.11/udf_verbose.c:696:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy((char *) chsp.inf, "OSTA Compressed Unicode"); data/udfclient-0.8.11/udf_verbose.c:1169:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy((char *) chsp.inf, "OSTA Compressed Unicode"); data/udfclient-0.8.11/udf_verbose.c:1339:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char fullpath[1024]; /* XXX arbitrary length XXX */ data/udfclient-0.8.11/udf_verbose.c:1444:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char scrap[100]; data/udfclient-0.8.11/udf_verbose.c:1472:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(scrap, "Reserved profile 0x%02x", profile); data/udfclient-0.8.11/udfclient.c:392:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pwd[1024]; data/udfclient-0.8.11/udfclient.c:529:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pwd[1024]; data/udfclient-0.8.11/udfclient.c:580:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cur_txt[32], avg_txt[32], eta_txt[32]; data/udfclient-0.8.11/udfclient.c:619:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fileh = open(fulldstname, O_WRONLY | O_CREAT | O_TRUNC, udf_node->stat.st_mode); data/udfclient-0.8.11/udfclient.c:638:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:638:27: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:638:51: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:676:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:676:29: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:676:53: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:677:24: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. if (avg_speed > 0) sprintf(avg_txt, "%d", (int32_t) avg_speed/1000); data/udfclient-0.8.11/udfclient.c:678:24: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. if (cur_speed > 0) sprintf(cur_txt, "%d", (int32_t) cur_speed/1000); data/udfclient-0.8.11/udfclient.c:679:24: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. if (eta > 0) sprintf(eta_txt, "%02d:%02d:%02d", (int) (eta/3600), (int) (eta/60) % 60, (int) eta % 60); data/udfclient-0.8.11/udfclient.c:714:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char fullsrcpath[1024], fulldstpath[1024]; /* XXX arbitrary length XXX */ data/udfclient-0.8.11/udfclient.c:909:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cur_txt[32], avg_txt[32], eta_txt[32]; data/udfclient-0.8.11/udfclient.c:918:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fileh = open(fullsrcname, O_RDONLY, 0666); data/udfclient-0.8.11/udfclient.c:952:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:952:26: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:952:50: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:997:4: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:997:28: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:997:52: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(avg_txt, "---"); strcpy(cur_txt, "---"); strcpy(eta_txt, "---"); data/udfclient-0.8.11/udfclient.c:998:23: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. if (avg_speed > 0) sprintf(avg_txt, "%d", (int32_t) avg_speed/1024); data/udfclient-0.8.11/udfclient.c:999:23: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. if (cur_speed > 0) sprintf(cur_txt, "%d", (int32_t) cur_speed/1024); data/udfclient-0.8.11/udfclient.c:1000:23: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. if (eta > 0) sprintf(eta_txt, "%02d:%02d:%02d", (int) (eta/3600), (int) (eta/60) % 60, (int) eta % 60); data/udfclient-0.8.11/udfclient.c:1020:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char fullsrcpath[1024], fulldstpath[1024]; data/udfclient-0.8.11/udfclient.c:1546:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *argv[MAX_ARGS+1]; data/udfclient-0.8.11/udfclient.c:1547:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[4096]; data/udfclient-0.8.11/udfclient.c:1702:19: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). udf_verbose = atoi(optarg); data/udfclient-0.8.11/udfclient.c:1721:23: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). alt_sector_size = atoi(optarg); data/udfclient-0.8.11/udfdump.c:190:19: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). udf_verbose = atoi(optarg); data/udfclient-0.8.11/udfdump.c:200:23: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). alt_sector_size = atoi(optarg); data/udfclient-0.8.11/uio.c:64:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(cp, iov->iov_base, cnt); data/udfclient-0.8.11/uio.c:67:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(iov->iov_base, cp, cnt); data/udfclient-0.8.11/uscsi_sense.c:54:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const char *sense_keys[16] = { data/udfclient-0.8.11/uscsi_sense.c:760:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char rqsbuf[132]; data/udfclient-0.8.11/uscsi_sense.c:774:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. auto char localbuf[64]; data/udfclient-0.8.11/uscsi_subr.c:89:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). disc->fhandle = open(disc->dev_name, O_RDWR, 0); /* no create */ data/udfclient-0.8.11/uscsi_subr.c:126:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(req.cmd, cmd, cmdlen); data/udfclient-0.8.11/uscsi_subr.c:246:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). disc->fhandle = open(disc->dev_name, O_RDWR | O_NONBLOCK, 0); data/udfclient-0.8.11/uscsi_subr.c:248:22: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). disc->fhandle = open(disc->dev_name, O_RDONLY | O_NONBLOCK, 0); data/udfclient-0.8.11/uscsi_subr.c:379:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). disc->fhandle = open(disc->dev_name, O_RDWR | O_NONBLOCK, 0); data/udfclient-0.8.11/uscsi_subr.c:449:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ccb.csio.cdb_io.cdb_bytes, cmd, cmdlen); data/udfclient-0.8.11/uscsi_subr.c:516:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). disc->fhandle = open(disc->dev_name, O_RDWR | O_NONBLOCK, 0); data/udfclient-0.8.11/uscsilib.h:48:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. typedef unsigned char scsicmd[SCSI_CMD_LEN]; data/udfclient-0.8.11/cd_disect.c:208:2: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(scrap, ""); data/udfclient-0.8.11/dirhash.h:43:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). # define DIRENT_NAMLEN(d) strlen((d)->d_name) data/udfclient-0.8.11/udf.c:139:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(result, id+1, len); data/udfclient-0.8.11/udf.c:166:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). udf_chars += strlen(name); data/udfclient-0.8.11/udf.c:189:2: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. strcat(unix_name, ":"); data/udfclient-0.8.11/udf.c:190:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). unix_name += strlen(unix_name); data/udfclient-0.8.11/udf.c:193:2: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. strcat(unix_name, ":"); data/udfclient-0.8.11/udf.c:194:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). unix_name += strlen(unix_name); data/udfclient-0.8.11/udf.c:197:2: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. strcat(unix_name, ":"); data/udfclient-0.8.11/udf.c:198:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). unix_name += strlen(unix_name); data/udfclient-0.8.11/udf.c:1636:3: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. usleep(100); data/udfclient-0.8.11/udf.c:1642:3: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. usleep(100); data/udfclient-0.8.11/udf.c:4694:2: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. usleep(1); data/udfclient-0.8.11/udf.c:4777:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). osta_id[len-1] = strlen(text)+1; data/udfclient-0.8.11/udf.c:5507:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). dirent->d_namlen = strlen(dirent->d_name); data/udfclient-0.8.11/udf.c:5545:3: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(dirent.d_name, "."); data/udfclient-0.8.11/udf.c:5960:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). dirent.d_namlen = strlen(dirent.d_name); data/udfclient-0.8.11/udf.c:6007:49: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). error = udf_lookup_name_in_dir(dir_node, name, strlen(name), &icb_loc, fid, &found); data/udfclient-0.8.11/udf.c:6317:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). namelen = strlen(name); data/udfclient-0.8.11/udf_discop.c:1279:7: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. usleep(5000); data/udfclient-0.8.11/udf_discop.c:1395:7: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. usleep(5000); data/udfclient-0.8.11/udfclient.c:156:49: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). error = udf_lookup_name_in_dir(dir_node, name, strlen(name), &udf_icbptr, fid, &found); data/udfclient-0.8.11/udfclient.c:205:26: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). while (next_element && (strlen(next_element) > 0)) { data/udfclient-0.8.11/udfclient.c:233:2: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(resultpath, "/"); data/udfclient-0.8.11/udfclient.c:235:2: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. strcat(resultpath, "/"); data/udfclient-0.8.11/udfclient.c:239:3: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(resultpath, ""); data/udfclient-0.8.11/udfclient.c:586:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). assert(strlen(fullsrcname) >= 1); data/udfclient-0.8.11/udfclient.c:593:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(fulldstname); data/udfclient-0.8.11/udfclient.c:659:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(fulldstname) < 45) { data/udfclient-0.8.11/udfclient.c:662:42: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). printf("\r...%-42s ", fulldstname + strlen(fulldstname)-42); data/udfclient-0.8.11/udfclient.c:960:11: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). error = read(fileh, file_block, file_transfer_size); data/udfclient-0.8.11/udfclient.c:980:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(fulldstname) < 45) { data/udfclient-0.8.11/udfclient.c:983:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). printf("\r...%-42s ", fulldstname+strlen(fulldstname)-42); data/udfclient-0.8.11/udfclient.c:1289:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). fullpath = malloc(strlen(full_parent_name) + strlen(dirent->d_name)+2); data/udfclient-0.8.11/udfclient.c:1289:51: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). fullpath = malloc(strlen(full_parent_name) + strlen(dirent->d_name)+2); data/udfclient-0.8.11/udfclient.c:1363:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(target_name); data/udfclient-0.8.11/uscsi_sense.c:607:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return strlen(src); ANALYSIS SUMMARY: Hits = 217 Lines analyzed = 23323 in approximately 0.74 seconds (31405 lines/second) Physical Source Lines of Code (SLOC) = 16483 Hits@level = [0] 1429 [1] 37 [2] 137 [3] 9 [4] 33 [5] 1 Hits@level+ = [0+] 1646 [1+] 217 [2+] 180 [3+] 43 [4+] 34 [5+] 1 Hits/KSLOC@level+ = [0+] 99.8605 [1+] 13.1651 [2+] 10.9203 [3+] 2.60875 [4+] 2.06273 [5+] 0.0606686 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.