Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/ukui-screensaver-3.0.1/VirtualKeyboard/src/cursormonitor.cpp
Examining data/ukui-screensaver-3.0.1/VirtualKeyboard/src/cursormonitor.h
Examining data/ukui-screensaver-3.0.1/VirtualKeyboard/src/keyboardwidget.cpp
Examining data/ukui-screensaver-3.0.1/VirtualKeyboard/src/virtualkeyboard.h
Examining data/ukui-screensaver-3.0.1/VirtualKeyboard/src/x11keyboard.h
Examining data/ukui-screensaver-3.0.1/VirtualKeyboard/src/main.cpp
Examining data/ukui-screensaver-3.0.1/VirtualKeyboard/src/keyboardwidget.h
Examining data/ukui-screensaver-3.0.1/VirtualKeyboard/src/x11keyboard.cpp
Examining data/ukui-screensaver-3.0.1/VirtualKeyboard/src/virtualkeyboard.cpp
Examining data/ukui-screensaver-3.0.1/Common/commonfunc.cpp
Examining data/ukui-screensaver-3.0.1/Common/autoresize.cpp
Examining data/ukui-screensaver-3.0.1/Common/checkbutton.h
Examining data/ukui-screensaver-3.0.1/Common/autoresize.h
Examining data/ukui-screensaver-3.0.1/Common/commonfunc.h
Examining data/ukui-screensaver-3.0.1/Common/checkbutton.cpp
Examining data/ukui-screensaver-3.0.1/screensaver/screensaver.cpp
Examining data/ukui-screensaver-3.0.1/screensaver/chinesedate.cpp
Examining data/ukui-screensaver-3.0.1/screensaver/mbackground.cpp
Examining data/ukui-screensaver-3.0.1/screensaver/chinesedate.h
Examining data/ukui-screensaver-3.0.1/screensaver/mbackground.h
Examining data/ukui-screensaver-3.0.1/screensaver/screensaver.h
Examining data/ukui-screensaver-3.0.1/screensaver/sleeptime.h
Examining data/ukui-screensaver-3.0.1/screensaver/main.cpp
Examining data/ukui-screensaver-3.0.1/screensaver/sleeptime.cpp
Examining data/ukui-screensaver-3.0.1/src/interface.cpp
Examining data/ukui-screensaver-3.0.1/src/ukui-screensaver-command.cpp
Examining data/ukui-screensaver-3.0.1/src/displaymanager.cpp
Examining data/ukui-screensaver-3.0.1/src/monitorwatcher.h
Examining data/ukui-screensaver-3.0.1/src/iconedit.h
Examining data/ukui-screensaver-3.0.1/src/logind.cpp
Examining data/ukui-screensaver-3.0.1/src/xeventmonitor.cpp
Examining data/ukui-screensaver-3.0.1/src/pam-tally.c
Examining data/ukui-screensaver-3.0.1/src/screensaverwidget.h
Examining data/ukui-screensaver-3.0.1/src/authdialog.h
Examining data/ukui-screensaver-3.0.1/src/users.h
Examining data/ukui-screensaver-3.0.1/src/unixsignallistener.cpp
Examining data/ukui-screensaver-3.0.1/src/generalauthwidget.h
Examining data/ukui-screensaver-3.0.1/src/screensaver.cpp
Examining data/ukui-screensaver-3.0.1/src/generalauthwidget.cpp
Examining data/ukui-screensaver-3.0.1/src/types.h
Examining data/ukui-screensaver-3.0.1/src/pam-tally.h
Examining data/ukui-screensaver-3.0.1/src/xeventmonitor.h
Examining data/ukui-screensaver-3.0.1/src/grab-x11.cpp
Examining data/ukui-screensaver-3.0.1/src/pam.cpp
Examining data/ukui-screensaver-3.0.1/src/authdialog.cpp
Examining data/ukui-screensaver-3.0.1/src/monitorwatcher.cpp
Examining data/ukui-screensaver-3.0.1/src/interface.h
Examining data/ukui-screensaver-3.0.1/src/grab-x11.h
Examining data/ukui-screensaver-3.0.1/src/sessionwatcher.h
Examining data/ukui-screensaver-3.0.1/src/sessionwatcher.cpp
Examining data/ukui-screensaver-3.0.1/src/powermanager.cpp
Examining data/ukui-screensaver-3.0.1/src/configuration.cpp
Examining data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp
Examining data/ukui-screensaver-3.0.1/src/unixsignallistener.h
Examining data/ukui-screensaver-3.0.1/src/logind.h
Examining data/ukui-screensaver-3.0.1/src/configuration.h
Examining data/ukui-screensaver-3.0.1/src/lockwidget.cpp
Examining data/ukui-screensaver-3.0.1/src/iconedit.cpp
Examining data/ukui-screensaver-3.0.1/src/auth.h
Examining data/ukui-screensaver-3.0.1/src/users.cpp
Examining data/ukui-screensaver-3.0.1/src/powermanager.h
Examining data/ukui-screensaver-3.0.1/src/screensaver.h
Examining data/ukui-screensaver-3.0.1/src/pam.h
Examining data/ukui-screensaver-3.0.1/src/auth-pam.cpp
Examining data/ukui-screensaver-3.0.1/src/displaymanager.h
Examining data/ukui-screensaver-3.0.1/src/fullbackgroundwidget.h
Examining data/ukui-screensaver-3.0.1/src/ukui-screensaver-backend.cpp
Examining data/ukui-screensaver-3.0.1/src/test-accounts.cpp
Examining data/ukui-screensaver-3.0.1/src/lockwidget.h
Examining data/ukui-screensaver-3.0.1/src/fullbackgroundwidget.cpp
Examining data/ukui-screensaver-3.0.1/src/screensaverwidget.cpp
Examining data/ukui-screensaver-3.0.1/src/auth-pam.h
Examining data/ukui-screensaver-3.0.1/BiometricAuth/biometricdeviceswidget.cpp
Examining data/ukui-screensaver-3.0.1/BiometricAuth/biometricproxy.h
Examining data/ukui-screensaver-3.0.1/BiometricAuth/biometricauthwidget.cpp
Examining data/ukui-screensaver-3.0.1/BiometricAuth/biometricdeviceswidget.h
Examining data/ukui-screensaver-3.0.1/BiometricAuth/biometricproxy.cpp
Examining data/ukui-screensaver-3.0.1/BiometricAuth/biometricauthwidget.h
Examining data/ukui-screensaver-3.0.1/BiometricAuth/main.cpp
Examining data/ukui-screensaver-3.0.1/BiometricAuth/biometricdeviceinfo.h
Examining data/ukui-screensaver-3.0.1/BiometricAuth/biometricdeviceinfo.cpp
FINAL RESULTS:
data/ukui-screensaver-3.0.1/screensaver/main.cpp:43:31: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
QString locale = QLocale::system().name();
data/ukui-screensaver-3.0.1/src/fullbackgroundwidget.cpp:79:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(srv_addr.sun_path, path);
data/ukui-screensaver-3.0.1/src/fullbackgroundwidget.cpp:97:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(path, "/var/lib/kydroid/%s/sockets/%s", container, "desktop-switch");
data/ukui-screensaver-3.0.1/src/fullbackgroundwidget.cpp:180:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(container,"kydroid2-%d-%s",uid,username);
data/ukui-screensaver-3.0.1/src/interface.cpp:93:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(cmd, "ps -aux | grep ukui-screensaver-dialog | grep %s | grep -v grep | wc -l", getenv("USER"));
data/ukui-screensaver-3.0.1/src/interface.cpp:95:10: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
fp = popen(cmd, "r");
data/ukui-screensaver-3.0.1/src/monitorwatcher.cpp:53:17: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
FILE * fp = popen("xrandr", "r");
data/ukui-screensaver-3.0.1/src/monitorwatcher.cpp:89:24: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
FILE *fp = popen("xrandr", "r");
data/ukui-screensaver-3.0.1/src/pam-tally.c:140:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(shm_tally_real, "%s_%d", SHM_TALLY, getuid());
data/ukui-screensaver-3.0.1/src/screensaverwidget.cpp:148:9: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(path.toStdString().c_str(), "xscreensaver", "-window-id", widStr, (char*)0);
data/ukui-screensaver-3.0.1/src/ukui-screensaver-backend.cpp:69:13: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
int n = sprintf(cmd, "ps aux | grep ukui-screensaver-backend | grep %s | grep -v grep | awk '{print $2}'", getenv("USER"));
data/ukui-screensaver-3.0.1/src/ukui-screensaver-backend.cpp:72:10: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
fp = popen(cmd, "r");
data/ukui-screensaver-3.0.1/src/ukui-screensaver-backend.cpp:84:10: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
fp = popen("xset s 0 0", "r");
data/ukui-screensaver-3.0.1/src/ukui-screensaver-command.cpp:33:31: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
QString locale = QLocale::system().name();
data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp:51:10: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
fp = popen(cmd, "r");
data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp:159:31: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
QString locale = QLocale::system().name();
data/ukui-screensaver-3.0.1/screensaver/screensaver.cpp:532:76: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
QDBusReply<QDBusObjectPath> reply = interface->call("FindUserByName", getenv("USER"));
data/ukui-screensaver-3.0.1/src/displaymanager.cpp:27:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *seatPath = getenv("XDG_SEAT_PATH");
data/ukui-screensaver-3.0.1/src/interface.cpp:93:93: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
sprintf(cmd, "ps -aux | grep ukui-screensaver-dialog | grep %s | grep -v grep | wc -l", getenv("USER"));
data/ukui-screensaver-3.0.1/src/lockwidget.cpp:46:42: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
UserItem user = users->getUserByName(getenv("USER"));
data/ukui-screensaver-3.0.1/src/pam.cpp:41:11: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
username=getenv("USER");
data/ukui-screensaver-3.0.1/src/ukui-screensaver-backend.cpp:69:112: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
int n = sprintf(cmd, "ps aux | grep ukui-screensaver-backend | grep %s | grep -v grep | awk '{print $2}'", getenv("USER"));
data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp:193:24: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
QString username = getenv("USER");
data/ukui-screensaver-3.0.1/VirtualKeyboard/src/virtualkeyboard.cpp:49:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
qssFile.open(QIODevice::ReadOnly);
data/ukui-screensaver-3.0.1/screensaver/mbackground.cpp:89:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file->open(QIODevice::ReadOnly))
data/ukui-screensaver-3.0.1/screensaver/screensaver.cpp:265:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(qssFile.open(QIODevice::ReadOnly)) {
data/ukui-screensaver-3.0.1/src/auth-pam.cpp:122:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r->resp, responseList[j].toLocal8Bit().data(), respLength);
data/ukui-screensaver-3.0.1/src/fullbackgroundwidget.cpp:96:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[1024] = {0};
data/ukui-screensaver-3.0.1/src/fullbackgroundwidget.cpp:178:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char container[100]= {0};
data/ukui-screensaver-3.0.1/src/interface.cpp:88:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmd[128] = {0};
data/ukui-screensaver-3.0.1/src/interface.cpp:89:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[4];
data/ukui-screensaver-3.0.1/src/interface.cpp:100:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
num = atoi(str);
data/ukui-screensaver-3.0.1/src/monitorwatcher.cpp:63:30: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(drmStatusFile.open(QIODevice::ReadOnly | QIODevice::Text)) {
data/ukui-screensaver-3.0.1/src/monitorwatcher.cpp:105:20: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(drmModeFile.open(QIODevice::ReadOnly | QIODevice::Text)) {
data/ukui-screensaver-3.0.1/src/pam-tally.c:32:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char shm_tally_real[128];
data/ukui-screensaver-3.0.1/src/pam-tally.c:43:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/ukui-screensaver-3.0.1/src/pam-tally.c:46:24: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if( (config_file = fopen(CONFIG_FILE, "r")) == NULL)
data/ukui-screensaver-3.0.1/src/pam-tally.c:108:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/ukui-screensaver-3.0.1/src/pam-tally.c:111:22: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if( (auth_file = fopen("/etc/pam.d/common-auth", "r")) == NULL)
data/ukui-screensaver-3.0.1/src/pam.cpp:58:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[16];
data/ukui-screensaver-3.0.1/src/pam.cpp:59:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%d", auth_status);
data/ukui-screensaver-3.0.1/src/pam.h:33:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[MAX_MSG_LENGTH + 1];
data/ukui-screensaver-3.0.1/src/screensaverwidget.cpp:144:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char widStr[20] = {0};
data/ukui-screensaver-3.0.1/src/ukui-screensaver-backend.cpp:64:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmd[128] = {0};
data/ukui-screensaver-3.0.1/src/ukui-screensaver-backend.cpp:65:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[16];
data/ukui-screensaver-3.0.1/src/ukui-screensaver-backend.cpp:74:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pid = atoi(str);
data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp:43:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmd[128] = {0};
data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp:44:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[1024];
data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp:48:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
int n = sprintf(cmd, "cat /proc/cmdline");
data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp:77:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp:91:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if( (fd = open(PID_FILE.toLocal8Bit().data(),
data/ukui-screensaver-3.0.1/src/ukui-screensaver-dialog.cpp:169:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(qssFile.open(QIODevice::ReadOnly)) {
data/ukui-screensaver-3.0.1/src/unixsignallistener.cpp:39:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[16];
data/ukui-screensaver-3.0.1/src/unixsignallistener.cpp:40:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%d", siginfo->si_pid);
data/ukui-screensaver-3.0.1/src/unixsignallistener.cpp:53:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[16];
data/ukui-screensaver-3.0.1/VirtualKeyboard/src/keyboardwidget.cpp:209:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int start = strlen("btn_");
data/ukui-screensaver-3.0.1/src/auth-pam.cpp:222:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int length = data ? strlen(data) : -1;
data/ukui-screensaver-3.0.1/src/auth-pam.cpp:231:21: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t nRead = read(fd, buf, count);
data/ukui-screensaver-3.0.1/src/pam-tally.c:54:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(buf) == 0 || buf[0] == '#')
data/ukui-screensaver-3.0.1/src/pam-tally.c:59:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(buf[strlen(buf)-1] == '\n')
data/ukui-screensaver-3.0.1/src/pam-tally.c:60:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf[strlen(buf)-1] = '\0';
data/ukui-screensaver-3.0.1/src/pam-tally.c:67:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(buf);
data/ukui-screensaver-3.0.1/src/pam-tally.c:78:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(p);
data/ukui-screensaver-3.0.1/src/pam-tally.c:115:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(buf) == 0 || buf[0] == '#')
data/ukui-screensaver-3.0.1/src/pam.cpp:61:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(toParent[1], buffer, strlen(buffer) + 1)
data/ukui-screensaver-3.0.1/src/pam.cpp:96:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(pam_msg_obj.msg, (*msg)->msg, MAX_MSG_LENGTH);
data/ukui-screensaver-3.0.1/src/pam.cpp:107:21: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
n = read(read_from_parent, password, MAX_PASSWORD_LENGTH);
data/ukui-screensaver-3.0.1/src/unixsignallistener.cpp:41:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int ignore = ::write(sigusr1Fd[0], buffer, strlen(buffer) + 1);
data/ukui-screensaver-3.0.1/src/unixsignallistener.cpp:55:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int ignore = ::read(sigusr1Fd[1], buffer, sizeof(buffer));
ANALYSIS SUMMARY:
Hits = 69
Lines analyzed = 10492 in approximately 0.31 seconds (33329 lines/second)
Physical Source Lines of Code (SLOC) = 7307
Hits@level = [0] 24 [1] 14 [2] 32 [3] 7 [4] 16 [5] 0
Hits@level+ = [0+] 93 [1+] 69 [2+] 55 [3+] 23 [4+] 16 [5+] 0
Hits/KSLOC@level+ = [0+] 12.7275 [1+] 9.443 [2+] 7.52703 [3+] 3.14767 [4+] 2.18968 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.