Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/urlview-0.9/snprintf.c
Examining data/urlview-0.9/enter.c
Examining data/urlview-0.9/dokey.c
Examining data/urlview-0.9/enter.h
Examining data/urlview-0.9/quote.c
Examining data/urlview-0.9/quote.h
Examining data/urlview-0.9/urlview.c
FINAL RESULTS:
data/urlview-0.9/snprintf.c:72:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int snprintf (char *str, size_t count, const char *fmt, ...);
data/urlview-0.9/snprintf.c:73:5: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int vsnprintf (char *str, size_t count, const char *fmt, va_list arg);
data/urlview-0.9/snprintf.c:85:5: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int vsnprintf (char *str, size_t count, const char *fmt, va_list args)
data/urlview-0.9/snprintf.c:94:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int snprintf (char *str,size_t count,const char *fmt,...)
data/urlview-0.9/snprintf.c:96:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int snprintf (va_alist) va_dcl
data/urlview-0.9/snprintf.c:110:10: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
(void) vsnprintf(str, count, fmt, ap);
data/urlview-0.9/snprintf.c:746:7: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf (buf1, sizeof (buf1), fp_fmt[x], fp_nums[y]);
data/urlview-0.9/snprintf.c:747:7: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf (buf2, fp_fmt[x], fp_nums[y]);
data/urlview-0.9/snprintf.c:760:7: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf (buf1, sizeof (buf1), int_fmt[x], int_nums[y]);
data/urlview-0.9/snprintf.c:761:7: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf (buf2, int_fmt[x], int_nums[y]);
data/urlview-0.9/urlview.c:614:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf (buf, sizeof (buf), part, scratch);
data/urlview-0.9/urlview.c:619:12: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (system (buf) == 0)
data/urlview-0.9/urlview.c:295:10: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
pc = getenv("BROWSER");
data/urlview-0.9/enter.c:144:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tempbuf[_POSIX_PATH_MAX] = "";
data/urlview-0.9/snprintf.c:442:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char convert[20];
data/urlview-0.9/snprintf.c:563:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iconvert[20];
data/urlview-0.9/snprintf.c:564:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fconvert[20];
data/urlview-0.9/snprintf.c:706:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf1[LONG_STRING];
data/urlview-0.9/snprintf.c:707:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf2[LONG_STRING];
data/urlview-0.9/urlview.c:155:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/urlview-0.9/urlview.c:156:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char command[1024];
data/urlview-0.9/urlview.c:157:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char regexp[1024];
data/urlview-0.9/urlview.c:158:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char search[1024];
data/urlview-0.9/urlview.c:159:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char scratch[1024];
data/urlview-0.9/urlview.c:160:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char wrapchoice[1024];
data/urlview-0.9/urlview.c:201:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen (buf, "r")))
data/urlview-0.9/urlview.c:346:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
startline = atoi(argv[optind]+1);
data/urlview-0.9/urlview.c:350:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
else if (!(fp = fopen (argv[optind], "r")))
data/urlview-0.9/urlview.c:380:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (url[urlcount], buf + match.rm_so + offset, len);
data/urlview-0.9/urlview.c:417:24: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
SLang_TT_Read_FD = open ("/dev/tty", O_RDONLY);
data/urlview-0.9/urlview.c:425:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = reopen_tty ? fopen ("/dev/tty", "r") : stdin;
data/urlview-0.9/urlview.c:642:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi (buf);
data/urlview-0.9/enter.c:153:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
lastchar = curpos = strlen ((char *) buf);
data/urlview-0.9/snprintf.c:89:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return(strlen(str));
data/urlview-0.9/snprintf.c:112:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return(strlen(str));
data/urlview-0.9/urlview.c:72:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(search) == 0 || *search == '\n')
data/urlview-0.9/urlview.c:110:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(search) == 0 || *search == '\n')
data/urlview-0.9/urlview.c:189:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (regexp, DEFAULT_REGEXP, sizeof (regexp) - 1);
data/urlview-0.9/urlview.c:190:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (command, DEFAULT_COMMAND, sizeof (command) - 1);
data/urlview-0.9/urlview.c:249:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pc[ strlen (pc) - 1 ] = 0; /* kill the trailing newline */
data/urlview-0.9/urlview.c:250:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (command, pc, sizeof (command) - 1);
data/urlview-0.9/urlview.c:259:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pc[ strlen (pc) - 1 ] = 0; /* kill the trailing newline */
data/urlview-0.9/urlview.c:260:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (wrapchoice, pc, sizeof (wrapchoice) - 1);
data/urlview-0.9/urlview.c:298:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(pc) > 0) {
data/urlview-0.9/urlview.c:299:11: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (command, pc, sizeof (command) - 1);
data/urlview-0.9/urlview.c:598:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (buf, url[current], sizeof (buf));
ANALYSIS SUMMARY:
Hits = 46
Lines analyzed = 2168 in approximately 0.06 seconds (36155 lines/second)
Physical Source Lines of Code (SLOC) = 1763
Hits@level = [0] 14 [1] 14 [2] 19 [3] 1 [4] 12 [5] 0
Hits@level+ = [0+] 60 [1+] 46 [2+] 32 [3+] 13 [4+] 12 [5+] 0
Hits/KSLOC@level+ = [0+] 34.0329 [1+] 26.0919 [2+] 18.1509 [3+] 7.37379 [4+] 6.80658 [5+] 0
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.