Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/utalk-1.0.1.beta/comm.c
Examining data/utalk-1.0.1.beta/functions.c
Examining data/utalk-1.0.1.beta/globals.c
Examining data/utalk-1.0.1.beta/kbd.c
Examining data/utalk-1.0.1.beta/menu.c
Examining data/utalk-1.0.1.beta/rc.c
Examining data/utalk-1.0.1.beta/screen.c
Examining data/utalk-1.0.1.beta/signal.c
Examining data/utalk-1.0.1.beta/srdp.c
Examining data/utalk-1.0.1.beta/termcap.c
Examining data/utalk-1.0.1.beta/termio.c
Examining data/utalk-1.0.1.beta/util.c
Examining data/utalk-1.0.1.beta/comm.h
Examining data/utalk-1.0.1.beta/functions.h
Examining data/utalk-1.0.1.beta/globals.h
Examining data/utalk-1.0.1.beta/kbd.h
Examining data/utalk-1.0.1.beta/menu.h
Examining data/utalk-1.0.1.beta/rc.h
Examining data/utalk-1.0.1.beta/screen.h
Examining data/utalk-1.0.1.beta/signal.h
Examining data/utalk-1.0.1.beta/srdp.h
Examining data/utalk-1.0.1.beta/srdpdata.h
Examining data/utalk-1.0.1.beta/struct.h
Examining data/utalk-1.0.1.beta/termio.h
Examining data/utalk-1.0.1.beta/util.h
Examining data/utalk-1.0.1.beta/termcap.h
Examining data/utalk-1.0.1.beta/utalk.c
FINAL RESULTS:
data/utalk-1.0.1.beta/comm.c:315:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(errstr, "No talk daemon on %s\n", machine);
data/utalk-1.0.1.beta/comm.c:543:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(users[1]->hostname, users[0]->hostname);
data/utalk-1.0.1.beta/comm.c:601:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(tmp, "%s@%s", users[1]->name, users[1]->hostname);
data/utalk-1.0.1.beta/kbd.c:272:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((char *)binding->sequence, (char *)sequence);
data/utalk-1.0.1.beta/menu.c:646:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(m->buf, m->entry + m->promptlen);
data/utalk-1.0.1.beta/menu.c:667:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(m->entry, prompt);
data/utalk-1.0.1.beta/menu.c:668:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(m->entry, buf);
data/utalk-1.0.1.beta/menu.c:677:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(help_txt[1], "help file %s %s.", HELPFILE, s);
data/utalk-1.0.1.beta/menu.c:717:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(&help_txt[line][1], buf+3);
data/utalk-1.0.1.beta/menu.c:718:14: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
} else strcpy(&help_txt[line][1], buf);
data/utalk-1.0.1.beta/menu.c:740:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(txt[1], r);
data/utalk-1.0.1.beta/menu.c:820:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(txt[1], s);
data/utalk-1.0.1.beta/rc.c:56:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(uh1, at);
data/utalk-1.0.1.beta/rc.c:72:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(at, a->to);
data/utalk-1.0.1.beta/rc.c:181:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((char *)b, (char *)home);
data/utalk-1.0.1.beta/screen.c:66:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(u->lefts, left);
data/utalk-1.0.1.beta/screen.c:87:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(u->lefts, left);
data/utalk-1.0.1.beta/rc.c:177:32: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((home = (unsigned char *)getenv("HOME")) == NULL)
data/utalk-1.0.1.beta/termcap.c:100:27: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((termtype = (char *)getenv("TERM")) == NULL) barf("No terminal type set");
data/utalk-1.0.1.beta/termio.c:48:20: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
lines = ((vr = getenv("LINES")) ? atoi(vr) : 0);
data/utalk-1.0.1.beta/termio.c:49:19: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
cols = ((vr = getenv("COLUMNS")) ? atoi(vr) : 0);
data/utalk-1.0.1.beta/comm.c:55:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char errstr[200];
data/utalk-1.0.1.beta/comm.c:136:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[200];
data/utalk-1.0.1.beta/comm.c:239:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(msg.remote_name,"^_^");
data/utalk-1.0.1.beta/comm.c:243:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(msg.local_name,"`&&'");
data/utalk-1.0.1.beta/comm.c:324:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char uh[256];
data/utalk-1.0.1.beta/comm.c:406:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(msg.local_name, "%d", u->info.localport);
data/utalk-1.0.1.beta/comm.c:505:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char tmp[256];
data/utalk-1.0.1.beta/comm.c:515:8: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
else strcpy(users[0]->name, "unknown");
data/utalk-1.0.1.beta/comm.c:518:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(users[0]->hostname, "unknown");
data/utalk-1.0.1.beta/comm.c:539:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(users[1]->name, "%d", port);
data/utalk-1.0.1.beta/comm.c:598:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(users[1]->name, "%d", users[1]->info.remoteport);
data/utalk-1.0.1.beta/comm.c:629:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char kbd_buf[256], *cp;
data/utalk-1.0.1.beta/comm.c:720:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)&line, ((char *)rc)+12, 2);
data/utalk-1.0.1.beta/comm.c:721:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)&col, ((char *)rc)+14, 2);
data/utalk-1.0.1.beta/comm.c:736:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)&line, (char *)s, 2);
data/utalk-1.0.1.beta/comm.c:738:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)&col, (char *)s, 2);
data/utalk-1.0.1.beta/comm.c:780:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(((char *)c)+12, (char *)&ll, 2);
data/utalk-1.0.1.beta/comm.c:781:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(((char *)c)+14, (char *)&cc, 2);
data/utalk-1.0.1.beta/comm.c:786:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((((char *)c)+16+buffered_len), (char *)&ll, 2);
data/utalk-1.0.1.beta/comm.c:788:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((((char *)c)+16+buffered_len), (char *)&cc, 2);
data/utalk-1.0.1.beta/comm.c:801:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((((char *)c)+16+buffered_len), (char *)s, len);
data/utalk-1.0.1.beta/comm.c:825:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char wb[2];
data/utalk-1.0.1.beta/comm.c:833:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char wb[2];
data/utalk-1.0.1.beta/comm.c:859:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(((char *)topic_c)+12, s, len+1);
data/utalk-1.0.1.beta/comm.h:40:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sin_zero[8];
data/utalk-1.0.1.beta/comm.h:46:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char local_name[NAME_SIZE];
data/utalk-1.0.1.beta/comm.h:47:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char remote_name[NAME_SIZE];
data/utalk-1.0.1.beta/comm.h:48:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char remote_tty[TTY_SIZE];
data/utalk-1.0.1.beta/comm.h:65:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char l_name[NAME_SIZE];
data/utalk-1.0.1.beta/comm.h:66:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_name[NAME_SIZE];
data/utalk-1.0.1.beta/comm.h:70:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_tty[TTY_SIZE];
data/utalk-1.0.1.beta/comm.h:88:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filler[2];
data/utalk-1.0.1.beta/comm.h:93:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char l_name[NAME_SIZE];
data/utalk-1.0.1.beta/comm.h:94:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char l_name_filler[3];
data/utalk-1.0.1.beta/comm.h:95:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_name[NAME_SIZE];
data/utalk-1.0.1.beta/comm.h:96:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_name_filler[3];
data/utalk-1.0.1.beta/comm.h:97:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_tty[TTY_SIZE];
data/utalk-1.0.1.beta/functions.c:244:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char nulls[512];
data/utalk-1.0.1.beta/kbd.c:179:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char *r, *nx, sequence[16], *w = sequence;
data/utalk-1.0.1.beta/kbd.c:180:19: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char s[200];
data/utalk-1.0.1.beta/kbd.c:325:19: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char seq[17];
data/utalk-1.0.1.beta/menu.c:684:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[256];
data/utalk-1.0.1.beta/menu.c:689:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(HELPFILE, "r");
data/utalk-1.0.1.beta/menu.c:699:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
hlines = atoi(buf);
data/utalk-1.0.1.beta/menu.c:748:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[256];
data/utalk-1.0.1.beta/menu.c:762:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[256];
data/utalk-1.0.1.beta/menu.c:783:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(txt[0], "Selection was: %d", n - 1);
data/utalk-1.0.1.beta/menu.c:797:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(txt[0], " YaY Menu! ");
data/utalk-1.0.1.beta/menu.c:798:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(txt[1], " ");
data/utalk-1.0.1.beta/menu.c:800:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(txt[i], " %c -- blah blah %d ", free_keys[i-2], i-1);
data/utalk-1.0.1.beta/menu.c:817:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(txt[0], "Entered text:");
data/utalk-1.0.1.beta/menu.c:827:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[256];
data/utalk-1.0.1.beta/menu.c:829:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "some default");
data/utalk-1.0.1.beta/menu.h:40:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char entry[256]; /* gets filled; can be initialized with a prompt;
data/utalk-1.0.1.beta/rc.c:38:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char uh1[256], *at;
data/utalk-1.0.1.beta/rc.c:171:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char b[300];
data/utalk-1.0.1.beta/rc.c:182:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat((char *)b, "/.utalkrc");
data/utalk-1.0.1.beta/rc.c:183:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen((char *)b, "r")) == NULL)
data/utalk-1.0.1.beta/screen.c:29:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char statusbuf[300];
data/utalk-1.0.1.beta/screen.c:32:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char left[12];
data/utalk-1.0.1.beta/screen.c:35:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(left, "[m]");
data/utalk-1.0.1.beta/screen.c:37:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(left, "[n]");
data/utalk-1.0.1.beta/screen.c:39:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(left, "[b]");
data/utalk-1.0.1.beta/screen.c:41:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(left, "[c]");
data/utalk-1.0.1.beta/screen.c:43:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(left, "[*]");
data/utalk-1.0.1.beta/screen.c:47:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(left, "[R]");
data/utalk-1.0.1.beta/screen.c:49:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(left, "---");
data/utalk-1.0.1.beta/screen.c:95:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(statusbuf+((cols+2-len)>>1), u->statuslines, len-2);
data/utalk-1.0.1.beta/screen.c:98:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(statusbuf+llen+4, u->statuslines, len-2);
data/utalk-1.0.1.beta/screen.c:100:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(statusbuf+1, left, llen);
data/utalk-1.0.1.beta/srdp.c:155:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)where, (char *)&nref, 4);
data/utalk-1.0.1.beta/srdp.c:167:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)wlen, (char *)&idx, 4);
data/utalk-1.0.1.beta/srdp.c:233:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)packbuf+sofar, (char *)cl->chunk,
data/utalk-1.0.1.beta/srdp.c:275:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)&junk, (char *)reading+4, 4);
data/utalk-1.0.1.beta/srdp.c:282:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)packbuf+sofar, (char *)reading, chunksize);
data/utalk-1.0.1.beta/srdp.c:300:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)&junk, (char *)reading+8, 4);
data/utalk-1.0.1.beta/srdp.c:313:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)packbuf+sofar, (char *)cl->next->chunk,
data/utalk-1.0.1.beta/srdp.c:328:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)&junk, (char *)reading+8, 4);
data/utalk-1.0.1.beta/srdp.c:347:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)&junk, (char *)reading, 4);
data/utalk-1.0.1.beta/srdp.c:358:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)packbuf+sofar, (char *)cl->chunk,
data/utalk-1.0.1.beta/srdp.c:384:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)packbuf+sofar, (char *)&junk, 4);
data/utalk-1.0.1.beta/srdp.c:386:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)packbuf+sofar+4, (char *)&junk, 4);
data/utalk-1.0.1.beta/srdp.c:401:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)packbuf+4, (char *)&junk, 4);
data/utalk-1.0.1.beta/srdp.c:424:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)c, (char *)reading, chunksize);
data/utalk-1.0.1.beta/srdp.c:429:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)&junk, (char *)&(c->u.sequenced.seq), 4);
data/utalk-1.0.1.beta/srdp.c:757:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)chunk, (char *)info->recvlist_first->chunk, csize);
data/utalk-1.0.1.beta/srdp.c:760:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)chunk, (char *)info->recvlist_first->chunk,
data/utalk-1.0.1.beta/srdp.c:804:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)c, (char *)chunk, ntohl(chunk->u.sequenced.len));
data/utalk-1.0.1.beta/struct.h:41:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[12], hostname[256], tty[16];
data/utalk-1.0.1.beta/struct.h:44:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char statuslines[300], lefts[12];
data/utalk-1.0.1.beta/struct.h:57:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[40];
data/utalk-1.0.1.beta/struct.h:67:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char sequence[16];
data/utalk-1.0.1.beta/struct.h:78:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char from[256], to[256];
data/utalk-1.0.1.beta/termcap.c:21:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char *termtype, termcap[2048], *tc, capabilities[2048];
data/utalk-1.0.1.beta/termcap.c:22:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char termcapbuf[2000];
data/utalk-1.0.1.beta/termcap.c:51:12: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
if (l>0) memcpy(termcapbuf+tcb, s, l);
data/utalk-1.0.1.beta/termcap.c:67:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
memset((char *)the_attrs[n], 0, cols+2);
data/utalk-1.0.1.beta/termcap.c:68:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
memset((char *)the_screen[n], ' ', cols+2);
data/utalk-1.0.1.beta/termcap.c:268:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char temp[16];
data/utalk-1.0.1.beta/termcap.c:270:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(temp, "\e[%d;%dr", y1, y2);
data/utalk-1.0.1.beta/termio.c:48:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
lines = ((vr = getenv("LINES")) ? atoi(vr) : 0);
data/utalk-1.0.1.beta/termio.c:49:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
cols = ((vr = getenv("COLUMNS")) ? atoi(vr) : 0);
data/utalk-1.0.1.beta/utalk.c:102:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(argv[2]);
data/utalk-1.0.1.beta/utalk.c:110:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(argv[3]);
data/utalk-1.0.1.beta/utalk.c:135:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(&argv[1][1]);
data/utalk-1.0.1.beta/comm.c:82:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (msg->type == ANNOUNCE && strlen(msg->local_name) < 8) {
data/utalk-1.0.1.beta/comm.c:84:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(&omsg.l_name[1], msg->local_name, NAME_SIZE-1);
data/utalk-1.0.1.beta/comm.c:86:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(omsg.l_name, msg->local_name, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:88:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(omsg.r_name, msg->remote_name, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:89:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(omsg.r_tty, msg->remote_tty, TTY_SIZE);
data/utalk-1.0.1.beta/comm.c:108:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(&nmsg.l_name[1], msg->local_name, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:110:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(nmsg.l_name, msg->local_name, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:112:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(nmsg.r_name, msg->remote_name, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:113:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(nmsg.r_tty, msg->remote_tty, TTY_SIZE);
data/utalk-1.0.1.beta/comm.c:237:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.remote_name, him, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:241:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.local_name, me, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:326:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(uh, h, 255);
data/utalk-1.0.1.beta/comm.c:330:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(users[1]->tty, s, 16);
data/utalk-1.0.1.beta/comm.c:342:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(users[1]->hostname, users[0]->hostname, 254);
data/utalk-1.0.1.beta/comm.c:344:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(users[1]->hostname, ++s, 254);
data/utalk-1.0.1.beta/comm.c:401:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.remote_tty, u->tty, TTY_SIZE);
data/utalk-1.0.1.beta/comm.c:404:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.remote_name, u->name, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:408:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.local_name, users[0]->name, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:455:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.remote_name, u->name, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:456:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.local_name, users[0]->name, NAME_SIZE);
data/utalk-1.0.1.beta/comm.c:514:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(users[0]->name, pw->pw_name, 8);
data/utalk-1.0.1.beta/comm.c:541:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(users[1]->hostname, h, 254);
data/utalk-1.0.1.beta/comm.c:599:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(users[1]->hostname, inet_ntoa(users[1]->info.remote), 254);
data/utalk-1.0.1.beta/comm.c:692:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
r = read(0, (char *)kbd_buf, 256);
data/utalk-1.0.1.beta/comm.c:853:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(s);
data/utalk-1.0.1.beta/kbd.c:193:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(s, line, 199);
data/utalk-1.0.1.beta/kbd.c:361:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(b->sequence) == inseq) {
data/utalk-1.0.1.beta/menu.c:129:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(*s) - the_menu->showfromcol;
data/utalk-1.0.1.beta/menu.c:154:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(s);
data/utalk-1.0.1.beta/menu.c:211:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(*s);
data/utalk-1.0.1.beta/menu.c:257:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m->len = strlen(m->entry);
data/utalk-1.0.1.beta/menu.c:663:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(buf) + strlen(prompt) > 256)
data/utalk-1.0.1.beta/menu.c:663:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(buf) + strlen(prompt) > 256)
data/utalk-1.0.1.beta/menu.c:664:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf[255 - strlen(prompt)] = 0;
data/utalk-1.0.1.beta/menu.c:665:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m->promptlen = strlen(prompt);
data/utalk-1.0.1.beta/menu.c:712:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
help_txt[line] = mymalloc(4 + strlen(buf));
data/utalk-1.0.1.beta/menu.c:719:7: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(help_txt[line], " ");
data/utalk-1.0.1.beta/menu.c:739:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
txt[1] = mymalloc(2 + strlen(r));
data/utalk-1.0.1.beta/menu.c:819:3: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(txt[1], "\"");
data/utalk-1.0.1.beta/menu.c:821:3: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(txt[1], "\"");
data/utalk-1.0.1.beta/rc.c:45:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(uh1, uh, 255);
data/utalk-1.0.1.beta/rc.c:52:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(uh1, a->to, 255);
data/utalk-1.0.1.beta/rc.c:55:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(uh1) + strlen(at) < 256)
data/utalk-1.0.1.beta/rc.c:55:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(uh1) + strlen(at) < 256)
data/utalk-1.0.1.beta/rc.c:62:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(uh1, uh, 255);
data/utalk-1.0.1.beta/rc.c:71:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(a->to) + (at - uh1) < 255)
data/utalk-1.0.1.beta/rc.c:89:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
r = b + strlen(b);
data/utalk-1.0.1.beta/rc.c:130:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(a->from, r+1, 255);
data/utalk-1.0.1.beta/rc.c:132:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(a->to, (*nx=='@' ? nx+1 : nx), 255);
data/utalk-1.0.1.beta/rc.c:134:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (at == r + strlen(r) - 1) {
data/utalk-1.0.1.beta/rc.c:137:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(a->from, r, 255);
data/utalk-1.0.1.beta/rc.c:139:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(a->to, nx, 255);
data/utalk-1.0.1.beta/rc.c:145:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(a->from, r, 255);
data/utalk-1.0.1.beta/rc.c:147:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(a->to, nx, 255);
data/utalk-1.0.1.beta/rc.c:179:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen((char *)home)>285)
data/utalk-1.0.1.beta/screen.c:67:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(left);
data/utalk-1.0.1.beta/screen.c:85:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
llen = strlen(left);
data/utalk-1.0.1.beta/screen.c:89:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(u->statuslines, s, 290);
data/utalk-1.0.1.beta/screen.c:91:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(u->statuslines)+2;
data/utalk-1.0.1.beta/termcap.c:271:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mywrite(temp, strlen(temp));
ANALYSIS SUMMARY:
Hits = 186
Lines analyzed = 6874 in approximately 0.20 seconds (34902 lines/second)
Physical Source Lines of Code (SLOC) = 5577
Hits@level = [0] 36 [1] 60 [2] 105 [3] 4 [4] 17 [5] 0
Hits@level+ = [0+] 222 [1+] 186 [2+] 126 [3+] 21 [4+] 17 [5+] 0
Hits/KSLOC@level+ = [0+] 39.8063 [1+] 33.3513 [2+] 22.5928 [3+] 3.76547 [4+] 3.04823 [5+] 0
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.