Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/votca-tools-1.6.2/include/votca/tools/akimaspline.h
Examining data/votca-tools-1.6.2/include/votca/tools/application.h
Examining data/votca-tools-1.6.2/include/votca/tools/average.h
Examining data/votca-tools-1.6.2/include/votca/tools/calculator.h
Examining data/votca-tools-1.6.2/include/votca/tools/colors.h
Examining data/votca-tools-1.6.2/include/votca/tools/constants.h
Examining data/votca-tools-1.6.2/include/votca/tools/correlate.h
Examining data/votca-tools-1.6.2/include/votca/tools/crosscorrelate.h
Examining data/votca-tools-1.6.2/include/votca/tools/cubicspline.h
Examining data/votca-tools-1.6.2/include/votca/tools/datacollection.h
Examining data/votca-tools-1.6.2/include/votca/tools/edge.h
Examining data/votca-tools-1.6.2/include/votca/tools/edgecontainer.h
Examining data/votca-tools-1.6.2/include/votca/tools/eigen.h
Examining data/votca-tools-1.6.2/include/votca/tools/eigensystem.h
Examining data/votca-tools-1.6.2/include/votca/tools/elements.h
Examining data/votca-tools-1.6.2/include/votca/tools/filesystem.h
Examining data/votca-tools-1.6.2/include/votca/tools/floatingpointcomparison.h
Examining data/votca-tools-1.6.2/include/votca/tools/getline.h
Examining data/votca-tools-1.6.2/include/votca/tools/globals.h
Examining data/votca-tools-1.6.2/include/votca/tools/graph.h
Examining data/votca-tools-1.6.2/include/votca/tools/graph_bf_visitor.h
Examining data/votca-tools-1.6.2/include/votca/tools/graph_df_visitor.h
Examining data/votca-tools-1.6.2/include/votca/tools/graphalgorithm.h
Examining data/votca-tools-1.6.2/include/votca/tools/graphdistvisitor.h
Examining data/votca-tools-1.6.2/include/votca/tools/graphnode.h
Examining data/votca-tools-1.6.2/include/votca/tools/graphvisitor.h
Examining data/votca-tools-1.6.2/include/votca/tools/histogram.h
Examining data/votca-tools-1.6.2/include/votca/tools/histogramnew.h
Examining data/votca-tools-1.6.2/include/votca/tools/identity.h
Examining data/votca-tools-1.6.2/include/votca/tools/lexical_cast.h
Examining data/votca-tools-1.6.2/include/votca/tools/linalg.h
Examining data/votca-tools-1.6.2/include/votca/tools/linspline.h
Examining data/votca-tools-1.6.2/include/votca/tools/mutex.h
Examining data/votca-tools-1.6.2/include/votca/tools/name.h
Examining data/votca-tools-1.6.2/include/votca/tools/objectfactory.h
Examining data/votca-tools-1.6.2/include/votca/tools/property.h
Examining data/votca-tools-1.6.2/include/votca/tools/propertyiomanipulator.h
Examining data/votca-tools-1.6.2/include/votca/tools/random.h
Examining data/votca-tools-1.6.2/include/votca/tools/rangeparser.h
Examining data/votca-tools-1.6.2/include/votca/tools/reducededge.h
Examining data/votca-tools-1.6.2/include/votca/tools/reducedgraph.h
Examining data/votca-tools-1.6.2/include/votca/tools/spline.h
Examining data/votca-tools-1.6.2/include/votca/tools/structureparameters.h
Examining data/votca-tools-1.6.2/include/votca/tools/table.h
Examining data/votca-tools-1.6.2/include/votca/tools/thread.h
Examining data/votca-tools-1.6.2/include/votca/tools/tokenizer.h
Examining data/votca-tools-1.6.2/include/votca/tools/types.h
Examining data/votca-tools-1.6.2/include/votca/tools/unitconverter.h
Examining data/votca-tools-1.6.2/include/votca/tools/version.h
Examining data/votca-tools-1.6.2/src/libtools/akimaspline.cc
Examining data/votca-tools-1.6.2/src/libtools/application.cc
Examining data/votca-tools-1.6.2/src/libtools/calculator.cc
Examining data/votca-tools-1.6.2/src/libtools/colors.cc
Examining data/votca-tools-1.6.2/src/libtools/correlate.cc
Examining data/votca-tools-1.6.2/src/libtools/crosscorrelate.cc
Examining data/votca-tools-1.6.2/src/libtools/cubicspline.cc
Examining data/votca-tools-1.6.2/src/libtools/datacollection.cc
Examining data/votca-tools-1.6.2/src/libtools/edge.cc
Examining data/votca-tools-1.6.2/src/libtools/edgecontainer.cc
Examining data/votca-tools-1.6.2/src/libtools/elements.cc
Examining data/votca-tools-1.6.2/src/libtools/filesystem.cc
Examining data/votca-tools-1.6.2/src/libtools/globals.cc
Examining data/votca-tools-1.6.2/src/libtools/graph.cc
Examining data/votca-tools-1.6.2/src/libtools/graph_bf_visitor.cc
Examining data/votca-tools-1.6.2/src/libtools/graph_df_visitor.cc
Examining data/votca-tools-1.6.2/src/libtools/graphalgorithm.cc
Examining data/votca-tools-1.6.2/src/libtools/graphdistvisitor.cc
Examining data/votca-tools-1.6.2/src/libtools/graphnode.cc
Examining data/votca-tools-1.6.2/src/libtools/graphvisitor.cc
Examining data/votca-tools-1.6.2/src/libtools/histogram.cc
Examining data/votca-tools-1.6.2/src/libtools/histogramnew.cc
Examining data/votca-tools-1.6.2/src/libtools/linalg.cc
Examining data/votca-tools-1.6.2/src/libtools/linspline.cc
Examining data/votca-tools-1.6.2/src/libtools/mutex.cc
Examining data/votca-tools-1.6.2/src/libtools/parcer.cc
Examining data/votca-tools-1.6.2/src/libtools/property.cc
Examining data/votca-tools-1.6.2/src/libtools/propertyiomanipulator.cc
Examining data/votca-tools-1.6.2/src/libtools/rangeparser.cc
Examining data/votca-tools-1.6.2/src/libtools/reducededge.cc
Examining data/votca-tools-1.6.2/src/libtools/reducedgraph.cc
Examining data/votca-tools-1.6.2/src/libtools/spline.cc
Examining data/votca-tools-1.6.2/src/libtools/table.cc
Examining data/votca-tools-1.6.2/src/libtools/thread.cc
Examining data/votca-tools-1.6.2/src/libtools/tokenizer.cc
Examining data/votca-tools-1.6.2/src/libtools/version.cc
Examining data/votca-tools-1.6.2/src/tests/test_akimaspline.cc
Examining data/votca-tools-1.6.2/src/tests/test_constants.cc
Examining data/votca-tools-1.6.2/src/tests/test_correlate.cc
Examining data/votca-tools-1.6.2/src/tests/test_crosscorrelate.cc
Examining data/votca-tools-1.6.2/src/tests/test_cubicspline.cc
Examining data/votca-tools-1.6.2/src/tests/test_datacollection.cc
Examining data/votca-tools-1.6.2/src/tests/test_edge_base.cc
Examining data/votca-tools-1.6.2/src/tests/test_edgecontainer.cc
Examining data/votca-tools-1.6.2/src/tests/test_elements.cc
Examining data/votca-tools-1.6.2/src/tests/test_filesystem.cc
Examining data/votca-tools-1.6.2/src/tests/test_floatingpointcomparison.cc
Examining data/votca-tools-1.6.2/src/tests/test_graph_base.cc
Examining data/votca-tools-1.6.2/src/tests/test_graph_bf_visitor.cc
Examining data/votca-tools-1.6.2/src/tests/test_graph_df_visitor.cc
Examining data/votca-tools-1.6.2/src/tests/test_graphalgorithm.cc
Examining data/votca-tools-1.6.2/src/tests/test_graphdistvisitor.cc
Examining data/votca-tools-1.6.2/src/tests/test_graphnode.cc
Examining data/votca-tools-1.6.2/src/tests/test_graphvisitor.cc
Examining data/votca-tools-1.6.2/src/tests/test_histogramnew.cc
Examining data/votca-tools-1.6.2/src/tests/test_identity.cc
Examining data/votca-tools-1.6.2/src/tests/test_linalg.cc
Examining data/votca-tools-1.6.2/src/tests/test_linspline.cc
Examining data/votca-tools-1.6.2/src/tests/test_name.cc
Examining data/votca-tools-1.6.2/src/tests/test_property.cc
Examining data/votca-tools-1.6.2/src/tests/test_random.cc
Examining data/votca-tools-1.6.2/src/tests/test_reducededge.cc
Examining data/votca-tools-1.6.2/src/tests/test_reducedgraph.cc
Examining data/votca-tools-1.6.2/src/tests/test_structureparameters.cc
Examining data/votca-tools-1.6.2/src/tests/test_table.cc
Examining data/votca-tools-1.6.2/src/tests/test_thread.cc
Examining data/votca-tools-1.6.2/src/tests/test_tokenizer.cc
Examining data/votca-tools-1.6.2/src/tests/test_unitconverter.cc
Examining data/votca-tools-1.6.2/src/tools/votca_property.cc
FINAL RESULTS:
data/votca-tools-1.6.2/src/libtools/application.cc:214:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *votca_share = getenv("VOTCASHARE");
data/votca-tools-1.6.2/src/libtools/application.cc:218:39: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
string xmlFile = (arg_path / string(getenv("VOTCASHARE")) / help_path /
data/votca-tools-1.6.2/src/libtools/calculator.cc:30:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *votca_share = getenv("VOTCASHARE");
data/votca-tools-1.6.2/src/libtools/calculator.cc:35:37: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
std::string xmlFile = std::string(getenv("VOTCASHARE")) + std::string("/") +
data/votca-tools-1.6.2/src/tests/test_random.cc:33:10: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
Random random;
data/votca-tools-1.6.2/src/tests/test_random.cc:35:3: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
random.init(seed);
data/votca-tools-1.6.2/src/tests/test_random.cc:36:3: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
random.setMaxInt(50);
data/votca-tools-1.6.2/src/tests/test_random.cc:41:23: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
results.push_back(random.rand_uniform_int());
data/votca-tools-1.6.2/src/tests/test_random.cc:52:10: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
Random random;
data/votca-tools-1.6.2/src/tests/test_random.cc:54:3: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
random.init(seed);
data/votca-tools-1.6.2/src/tests/test_random.cc:59:23: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
results.push_back(random.rand_uniform());
data/votca-tools-1.6.2/src/libtools/property.cc:158:6: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fl.open(filename);
data/votca-tools-1.6.2/src/libtools/table.cc:44:6: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
in.open(filename);
data/votca-tools-1.6.2/src/libtools/table.cc:56:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
out.open(filename);
data/votca-tools-1.6.2/src/tests/test_linalg.cc:55:8: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
if (!equal) {
data/votca-tools-1.6.2/src/tests/test_linalg.cc:61:21: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
BOOST_CHECK_EQUAL(equal, true);
data/votca-tools-1.6.2/src/tests/test_table.cc:152:8: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
if (!equal) {
data/votca-tools-1.6.2/src/tests/test_table.cc:158:21: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
BOOST_CHECK_EQUAL(equal, true);
ANALYSIS SUMMARY:
Hits = 18
Lines analyzed = 16315 in approximately 0.47 seconds (34943 lines/second)
Physical Source Lines of Code (SLOC) = 9875
Hits@level = [0] 0 [1] 4 [2] 3 [3] 11 [4] 0 [5] 0
Hits@level+ = [0+] 18 [1+] 18 [2+] 14 [3+] 11 [4+] 0 [5+] 0
Hits/KSLOC@level+ = [0+] 1.82278 [1+] 1.82278 [2+] 1.41772 [3+] 1.11392 [4+] 0 [5+] 0
Dot directories skipped = 2 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.