Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/wavbreaker-0.13/src/about.c
Examining data/wavbreaker-0.13/src/about.h
Examining data/wavbreaker-0.13/src/aoaudio.c
Examining data/wavbreaker-0.13/src/aoaudio.h
Examining data/wavbreaker-0.13/src/appconfig.c
Examining data/wavbreaker-0.13/src/appconfig.h
Examining data/wavbreaker-0.13/src/autosplit.c
Examining data/wavbreaker-0.13/src/autosplit.h
Examining data/wavbreaker-0.13/src/cdda.c
Examining data/wavbreaker-0.13/src/cdda.h
Examining data/wavbreaker-0.13/src/cue.c
Examining data/wavbreaker-0.13/src/cue.h
Examining data/wavbreaker-0.13/src/draw.c
Examining data/wavbreaker-0.13/src/draw.h
Examining data/wavbreaker-0.13/src/gettext.h
Examining data/wavbreaker-0.13/src/guimerge.c
Examining data/wavbreaker-0.13/src/guimerge.h
Examining data/wavbreaker-0.13/src/moodbar.c
Examining data/wavbreaker-0.13/src/moodbar.h
Examining data/wavbreaker-0.13/src/overwritedialog.c
Examining data/wavbreaker-0.13/src/overwritedialog.h
Examining data/wavbreaker-0.13/src/popupmessage.c
Examining data/wavbreaker-0.13/src/popupmessage.h
Examining data/wavbreaker-0.13/src/reallyquit.c
Examining data/wavbreaker-0.13/src/reallyquit.h
Examining data/wavbreaker-0.13/src/sample.c
Examining data/wavbreaker-0.13/src/sample.h
Examining data/wavbreaker-0.13/src/saveas.c
Examining data/wavbreaker-0.13/src/saveas.h
Examining data/wavbreaker-0.13/src/toc.c
Examining data/wavbreaker-0.13/src/toc.h
Examining data/wavbreaker-0.13/src/wav.c
Examining data/wavbreaker-0.13/src/wav.h
Examining data/wavbreaker-0.13/src/wavbreaker.c
Examining data/wavbreaker-0.13/src/wavbreaker.h
Examining data/wavbreaker-0.13/src/wavgen.c
Examining data/wavbreaker-0.13/src/wavinfo.c
Examining data/wavbreaker-0.13/src/wavmerge.c
FINAL RESULTS:
data/wavbreaker-0.13/src/cue.c:43:6: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
if (sscanf(line_buf, "FILE %s WAVE", buf) != 1) {
data/wavbreaker-0.13/src/cue.c:68:10: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
read = sscanf(line_buf, "INDEX %02d %s", &N, buf);
data/wavbreaker-0.13/src/guimerge.c:214:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(folder, current_folder);
data/wavbreaker-0.13/src/moodbar.c:103:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(fn, filename);
data/wavbreaker-0.13/src/moodbar.c:131:7: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (execlp("moodbar", "moodbar", "-o", moodbar_filename, filename, (char*)NULL) == -1) {
data/wavbreaker-0.13/src/sample.c:795:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(filename, outputdir);
data/wavbreaker-0.13/src/sample.c:798:13: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(filename, tb_cur->filename);
data/wavbreaker-0.13/src/wavbreaker.c:761:13: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf, "%02d%s", index, appconfig_get_etree_filename_suffix());
data/wavbreaker-0.13/src/wavbreaker.c:763:13: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf, "%s%02d", appconfig_get_etree_filename_suffix(), index);
data/wavbreaker-0.13/src/wavbreaker.c:770:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(fn, buf);
data/wavbreaker-0.13/src/wavbreaker.c:771:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(fn, orig_filename);
data/wavbreaker-0.13/src/wavbreaker.c:773:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(fn, orig_filename);
data/wavbreaker-0.13/src/wavbreaker.c:774:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(fn, buf);
data/wavbreaker-0.13/src/wavbreaker.c:1276:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat( tmp_str, gtk_window_get_title( GTK_WINDOW( window)));
data/wavbreaker-0.13/src/wavbreaker.c:1292:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf( tmp_str, _("Analyzing %s"), basename( sample_filename));
data/wavbreaker-0.13/src/wavbreaker.c:1294:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf( tmp_str2, "<i>%s</i>", str);
data/wavbreaker-0.13/src/wavbreaker.c:1433:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf( buf, "%s (%s)", APPNAME, title);
data/wavbreaker-0.13/src/wavbreaker.c:1723:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy( tmp, tbs[i]->filename);
data/wavbreaker-0.13/src/wavbreaker.c:2122:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(str, strbuf);
data/wavbreaker-0.13/src/wavbreaker.c:2129:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(str, strbuf);
data/wavbreaker-0.13/src/wavbreaker.c:2282:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy( new_filename, base);
data/wavbreaker-0.13/src/appconfig.c:704:30: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
outputdir = g_strdup(getenv("PWD"));
data/wavbreaker-0.13/src/saveas.c:57:29: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
saveas_set_dirname( getenv( "PWD"));
data/wavbreaker-0.13/src/autosplit.c:42:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
return atoi(autosplit_time) * 60 * CD_BLOCKS_PER_SEC;
data/wavbreaker-0.13/src/cdda.c:94:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[buf_size];
data/wavbreaker-0.13/src/cdda.c:96:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((new_fp = fopen(filename, "wb")) == NULL) {
data/wavbreaker-0.13/src/cue.c:27:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line_buf[1024];
data/wavbreaker-0.13/src/cue.c:28:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/wavbreaker-0.13/src/cue.c:31:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(cue_filename, "r");
data/wavbreaker-0.13/src/guimerge.c:50:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char folder[4096] = {0};
data/wavbreaker-0.13/src/guimerge.c:149:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy( &common_sample_info, &sampleinfo, sizeof(SampleInfo));
data/wavbreaker-0.13/src/guimerge.c:167:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf( length_str, "%02d:%02d", length/60, length%60);
data/wavbreaker-0.13/src/moodbar.c:104:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy((gchar*)(fn+strlen(fn)-4), ".mood");
data/wavbreaker-0.13/src/moodbar.c:173:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fn, "rb");
data/wavbreaker-0.13/src/sample.c:197:25: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *output_file = fopen(filename, "wb");
data/wavbreaker-0.13/src/sample.c:566:31: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((read_sample_fp = fopen(sample_file, "rb")) == NULL) {
data/wavbreaker-0.13/src/sample.c:612:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char devbuf[sampleInfo.blockSize];
data/wavbreaker-0.13/src/sample.c:753:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[1024];
data/wavbreaker-0.13/src/sample.c:802:17: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(filename, ".wav");
data/wavbreaker-0.13/src/sample.c:804:17: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(filename, ".dat");
data/wavbreaker-0.13/src/sample.c:807:17: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(filename, ".mp3");
data/wavbreaker-0.13/src/sample.c:881:28: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((write_sample_fp = fopen(sample_file, "rb")) == NULL) {
data/wavbreaker-0.13/src/sample.c:894:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *filenames[g_list_length(thread_data->filenames)];
data/wavbreaker-0.13/src/toc.c:33:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/wavbreaker-0.13/src/toc.c:37:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen( toc_filename, "r" );
data/wavbreaker-0.13/src/toc.c:87:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(toc_filename, "w");
data/wavbreaker-0.13/src/wav.c:59:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[128];
data/wavbreaker-0.13/src/wav.c:84:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen(sample_file, "rb")) == NULL) {
data/wavbreaker-0.13/src/wav.c:105:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, wavHdr.riffID, 4);
data/wavbreaker-0.13/src/wav.c:106:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str+4, "\0", 1);
data/wavbreaker-0.13/src/wav.c:111:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, wavHdr.wavID, 4);
data/wavbreaker-0.13/src/wav.c:112:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str+4, "\0", 1);
data/wavbreaker-0.13/src/wav.c:127:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, chunkHdr.chunkID, 4);
data/wavbreaker-0.13/src/wav.c:128:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str+4, "\0", 1);
data/wavbreaker-0.13/src/wav.c:134:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, chunkHdr.chunkID, 4);
data/wavbreaker-0.13/src/wav.c:135:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str+4, "\0", 1);
data/wavbreaker-0.13/src/wav.c:152:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, chunkHdr.chunkID, 4);
data/wavbreaker-0.13/src/wav.c:153:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str+4, "\0", 1);
data/wavbreaker-0.13/src/wav.c:208:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, chunkHdr.chunkID, 4);
data/wavbreaker-0.13/src/wav.c:209:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str + 4, "\0", 1);
data/wavbreaker-0.13/src/wav.c:303:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(wavHdr.riffID, RiffID, 4);
data/wavbreaker-0.13/src/wav.c:306:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(wavHdr.wavID, WaveID, 4);
data/wavbreaker-0.13/src/wav.c:314:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(chunkHdr.chunkID, FormatID, 4);
data/wavbreaker-0.13/src/wav.c:336:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(chunkHdr.chunkID, WaveDataID, 4);
data/wavbreaker-0.13/src/wav.c:361:19: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((new_fp = fopen(filename, "wb")) == NULL) {
data/wavbreaker-0.13/src/wav.c:458:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[buf_size];
data/wavbreaker-0.13/src/wav.c:495:19: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((new_fp = fopen(filename, "wb")) == NULL) {
data/wavbreaker-0.13/src/wav.c:515:24: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((read_fp = fopen(filenames[i], "rb")) == NULL) {
data/wavbreaker-0.13/src/wav.h:29:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
typedef char ID[4];
data/wavbreaker-0.13/src/wavbreaker.c:746:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int cd_length = atoi(appconfig_get_etree_cd_length());
data/wavbreaker-0.13/src/wavbreaker.c:758:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "d%dt%02d", disc_num, track_num);
data/wavbreaker-0.13/src/wavbreaker.c:790:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(path_str, "%d", index);
data/wavbreaker-0.13/src/wavbreaker.c:1001:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
list_pos = atoi(path_str);
data/wavbreaker-0.13/src/wavbreaker.c:1035:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
list_pos = atoi(path_str);
data/wavbreaker-0.13/src/wavbreaker.c:1059:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
list_pos = atoi(path_str);
data/wavbreaker-0.13/src/wavbreaker.c:1251:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char tmp_str[6144];
data/wavbreaker-0.13/src/wavbreaker.c:1252:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char tmp_str2[6144];
data/wavbreaker-0.13/src/wavbreaker.c:1275:9: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat( tmp_str, "<span size=\"larger\" weight=\"bold\">");
data/wavbreaker-0.13/src/wavbreaker.c:1277:9: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat( tmp_str, "</span>");
data/wavbreaker-0.13/src/wavbreaker.c:1346:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf( tmp_str, _("%d of %d MB analyzed"), current, size);
data/wavbreaker-0.13/src/wavbreaker.c:1425:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/wavbreaker-0.13/src/wavbreaker.c:1617:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[1024];
data/wavbreaker-0.13/src/wavbreaker.c:1732:13: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat( tmp, "...");
data/wavbreaker-0.13/src/wavbreaker.c:2112:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(str, "%d:%02d.%02d", min, sec, subsec);
data/wavbreaker-0.13/src/wavbreaker.c:2116:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[1024];
data/wavbreaker-0.13/src/wavbreaker.c:2117:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strbuf[1024];
data/wavbreaker-0.13/src/wavbreaker.c:2119:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf( str, _("Cursor"));
data/wavbreaker-0.13/src/wavbreaker.c:2120:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat( str, ": ");
data/wavbreaker-0.13/src/wavbreaker.c:2126:9: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat( str, _("Playing"));
data/wavbreaker-0.13/src/wavbreaker.c:2127:9: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat( str, ": ");
data/wavbreaker-0.13/src/wavbreaker.c:2291:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat( new_filename, ".txt");
data/wavbreaker-0.13/src/wavbreaker.c:2293:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat( new_filename, ".toc");
data/wavbreaker-0.13/src/wavbreaker.c:2295:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat( new_filename, ".cue");
data/wavbreaker-0.13/src/wavbreaker.c:2313:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy( filename + strlen( filename) - 3, "txt");
data/wavbreaker-0.13/src/wavbreaker.c:2366:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy( filename + strlen( filename) - 3, "txt");
data/wavbreaker-0.13/src/wavbreaker.c:3028:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen( filename, "w");
data/wavbreaker-0.13/src/wavbreaker.c:3053:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen( filename, "w");
data/wavbreaker-0.13/src/wavbreaker.c:3110:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[1024];
data/wavbreaker-0.13/src/wavbreaker.c:3115:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen( filename, "r");
data/wavbreaker-0.13/src/wavbreaker.c:3135:50: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
track_break_add_offset(NULL, atol(tmp));
data/wavbreaker-0.13/src/wavbreaker.c:3141:51: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
track_break_add_offset(fname, atol(tmp));
data/wavbreaker-0.13/src/wavgen.c:144:24: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(filename, "wb");
data/wavbreaker-0.13/src/cue.c:50:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int read;
data/wavbreaker-0.13/src/cue.c:58:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read != 1 || N != next_track) {
data/wavbreaker-0.13/src/cue.c:69:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read != 2 || N != 1) {
data/wavbreaker-0.13/src/guimerge.c:120:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen( folder) > 0) {
data/wavbreaker-0.13/src/guimerge.c:207:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen( folder) > 0) {
data/wavbreaker-0.13/src/moodbar.c:102:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gchar *fn = (gchar*)malloc(strlen(filename)+2);
data/wavbreaker-0.13/src/moodbar.c:104:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strcpy((gchar*)(fn+strlen(fn)-4), ".mood");
data/wavbreaker-0.13/src/sample.c:215:17: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int a = fgetc(input_file);
data/wavbreaker-0.13/src/sample.c:796:13: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(filename, "/");
data/wavbreaker-0.13/src/wavbreaker.c:730:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int length = strlen(track_break->filename);
data/wavbreaker-0.13/src/wavbreaker.c:731:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int orig_length = strlen(orig_filename);
data/wavbreaker-0.13/src/wavbreaker.c:1726:96: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
while( border_left + te.width + ellipsis_width + border*2 > border_right - border*2 && strlen( tmp) > 1) {
data/wavbreaker-0.13/src/wavbreaker.c:1727:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen( tmp)-1] = '\0';
data/wavbreaker-0.13/src/wavbreaker.c:2125:9: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat( str, "\t");
data/wavbreaker-0.13/src/wavbreaker.c:2281:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
new_filename = malloc( strlen(base) + 4);
data/wavbreaker-0.13/src/wavbreaker.c:2285:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dot = new_filename + strlen(new_filename);
data/wavbreaker-0.13/src/wavbreaker.c:2313:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strcpy( filename + strlen( filename) - 3, "txt");
data/wavbreaker-0.13/src/wavbreaker.c:2366:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strcpy( filename + strlen( filename) - 3, "txt");
data/wavbreaker-0.13/src/wavbreaker.c:3125:13: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c = fgetc( fp);
ANALYSIS SUMMARY:
Hits = 121
Lines analyzed = 8359 in approximately 0.22 seconds (37840 lines/second)
Physical Source Lines of Code (SLOC) = 5759
Hits@level = [0] 130 [1] 19 [2] 79 [3] 2 [4] 21 [5] 0
Hits@level+ = [0+] 251 [1+] 121 [2+] 102 [3+] 23 [4+] 21 [5+] 0
Hits/KSLOC@level+ = [0+] 43.584 [1+] 21.0106 [2+] 17.7114 [3+] 3.99375 [4+] 3.64647 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.