Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/wmpinboard-1.0.1/src/xmisc.c Examining data/wmpinboard-1.0.1/src/misc.h Examining data/wmpinboard-1.0.1/src/getopt.h Examining data/wmpinboard-1.0.1/src/memcmp.c Examining data/wmpinboard-1.0.1/src/memcmp.h Examining data/wmpinboard-1.0.1/src/misc.c Examining data/wmpinboard-1.0.1/src/notes.c Examining data/wmpinboard-1.0.1/src/getopt.c Examining data/wmpinboard-1.0.1/src/getopt1.c Examining data/wmpinboard-1.0.1/src/xmisc.h Examining data/wmpinboard-1.0.1/src/notes.h Examining data/wmpinboard-1.0.1/src/wmpinboard.h Examining data/wmpinboard-1.0.1/src/wmpinboard.c FINAL RESULTS: data/wmpinboard-1.0.1/src/misc.c:79:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(s, getenv("HOME")); data/wmpinboard-1.0.1/src/misc.c:80:5: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(s, rc_file_name); data/wmpinboard-1.0.1/src/misc.c:109:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(t, s); data/wmpinboard-1.0.1/src/notes.c:745:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(ndata[note].text, s); data/wmpinboard-1.0.1/src/notes.c:759:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(ndata[note].text, s); data/wmpinboard-1.0.1/src/notes.c:771:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(ndata[note].text, s); data/wmpinboard-1.0.1/src/notes.c:833:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(s, ndata[note].text); data/wmpinboard-1.0.1/src/wmpinboard.c:185:3: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(s, rc_file_name); data/wmpinboard-1.0.1/src/wmpinboard.c:187:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(t, s); data/wmpinboard-1.0.1/src/wmpinboard.c:188:5: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(s, ext); data/wmpinboard-1.0.1/src/wmpinboard.c:215:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(s, t); data/wmpinboard-1.0.1/src/wmpinboard.c:216:5: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(s, ext); data/wmpinboard-1.0.1/src/wmpinboard.c:403:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(p, s); data/wmpinboard-1.0.1/src/wmpinboard.c:688:11: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(opts.font, fonts[i].font); data/wmpinboard-1.0.1/src/wmpinboard.c:698:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(opts.font, data); data/wmpinboard-1.0.1/src/wmpinboard.c:714:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(opts.theme, data); data/wmpinboard-1.0.1/src/wmpinboard.c:733:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(opts.alarm_cmd, data); data/wmpinboard-1.0.1/src/wmpinboard.c:952:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(opts.display, optarg); data/wmpinboard-1.0.1/src/wmpinboard.c:1000:9: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf("wmpinboard v" VERSION "\n\ncompile-time configuration:\n" data/wmpinboard-1.0.1/src/wmpinboard.c:2262:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(buf, opts.alarm_cmd); data/wmpinboard-1.0.1/src/wmpinboard.c:2264:13: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if (system(buf)) data/wmpinboard-1.0.1/src/xmisc.c:171:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(tmp, rs_inputMethod); data/wmpinboard-1.0.1/src/xmisc.c:185:9: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(buf, s); data/wmpinboard-1.0.1/src/xmisc.c:215:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(tmp, (rs_preeditType ? rs_preeditType : "Root")); data/wmpinboard-1.0.1/src/getopt.c:213:7: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char *getenv(); data/wmpinboard-1.0.1/src/getopt.c:368:20: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. posixly_correct = getenv("POSIXLY_CORRECT"); data/wmpinboard-1.0.1/src/getopt.c:398:21: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. nonoption_flags = getenv(var); data/wmpinboard-1.0.1/src/getopt.c:921:5: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. getopt(argc, argv, optstring) data/wmpinboard-1.0.1/src/getopt.c:951:7: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. c = getopt(argc, argv, "abc:d:0123456789"); data/wmpinboard-1.0.1/src/getopt.h:107:13: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. extern int getopt(int argc, char *const *argv, const char *shortopts); data/wmpinboard-1.0.1/src/getopt.h:109:13: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. extern int getopt(); data/wmpinboard-1.0.1/src/getopt.h:111:13: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. extern int getopt_long(int argc, char *const *argv, const char *shortopts, data/wmpinboard-1.0.1/src/getopt.h:123:13: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. extern int getopt(); data/wmpinboard-1.0.1/src/getopt.h:124:13: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. extern int getopt_long(); data/wmpinboard-1.0.1/src/getopt1.c:67:5: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. getopt_long(argc, argv, options, long_options, opt_index) data/wmpinboard-1.0.1/src/getopt1.c:122:7: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. c = getopt_long(argc, argv, "abc:d:0123456789", data/wmpinboard-1.0.1/src/misc.c:78:24: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. s = smalloc(strlen(getenv("HOME")) + strlen(rc_file_name) + 1); data/wmpinboard-1.0.1/src/misc.c:79:15: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. strcpy(s, getenv("HOME")); data/wmpinboard-1.0.1/src/wmpinboard.c:180:8: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (!getenv("HOME")) data/wmpinboard-1.0.1/src/wmpinboard.c:182:14: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. strncpy(s, getenv("HOME"), sizeof(s)); data/wmpinboard-1.0.1/src/wmpinboard.c:943:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. if ((c = getopt_long(argc, argv, short_opts, long_opts, &idx)) == -1) data/wmpinboard-1.0.1/src/wmpinboard.c:2136:3: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand(time(0)); data/wmpinboard-1.0.1/src/getopt.c:395:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char var[100]; data/wmpinboard-1.0.1/src/getopt.c:397:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(var, "_%d_GNU_nonoption_argv_flags_", getpid()); data/wmpinboard-1.0.1/src/notes.c:99:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&ndata[i], &ndata[i+1], sizeof(data_t)); data/wmpinboard-1.0.1/src/notes.c:113:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&tmp, &ndata[number], sizeof(data_t)); data/wmpinboard-1.0.1/src/notes.c:116:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&ndata[i], &ndata[i+1], sizeof(data_t)); data/wmpinboard-1.0.1/src/notes.c:117:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&ndata[notes_count-1], &tmp, sizeof(data_t)); data/wmpinboard-1.0.1/src/notes.c:491:25: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const unsigned char pat[8][5][5] = { data/wmpinboard-1.0.1/src/notes.c:579:19: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char l[(64/8)*64]; /* high res crease map */ data/wmpinboard-1.0.1/src/notes.c:580:19: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char m[32]; /* low res crease map */ data/wmpinboard-1.0.1/src/notes.c:636:25: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const unsigned char sketch0[256] = { data/wmpinboard-1.0.1/src/notes.c:670:25: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const unsigned char sketch1[512] = { data/wmpinboard-1.0.1/src/notes.c:742:7: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&ndata[note].sketch[256], sketch0, 256); data/wmpinboard-1.0.1/src/notes.c:756:7: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ndata[note].sketch, sketch1, 512); data/wmpinboard-1.0.1/src/notes.c:862:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&data, ptr, sizeof(struct tm)); data/wmpinboard-1.0.1/src/notes.c:922:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&data, ptr, sizeof(struct tm)); data/wmpinboard-1.0.1/src/notes.c:950:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&atm, ptr, sizeof(struct tm)); data/wmpinboard-1.0.1/src/wmpinboard.c:45:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. const char c_group[C_NUM] = /* group available note colors */ data/wmpinboard-1.0.1/src/wmpinboard.c:50:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[8]; data/wmpinboard-1.0.1/src/wmpinboard.c:51:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char desc[40]; data/wmpinboard-1.0.1/src/wmpinboard.c:52:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char font[60]; data/wmpinboard-1.0.1/src/wmpinboard.c:155:58: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const int size_0 = sizeof(struct { int a, b, c; char d[60]; }); data/wmpinboard-1.0.1/src/wmpinboard.c:157:34: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. sizeof(struct { int a, b, c; char d[60]; int e; char f[512]; }); data/wmpinboard-1.0.1/src/wmpinboard.c:157:53: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. sizeof(struct { int a, b, c; char d[60]; int e; char f[512]; }); data/wmpinboard-1.0.1/src/wmpinboard.c:159:34: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. sizeof(struct { int a, b, c; char d[60]; int e; char f[512]; char g[32]; }); data/wmpinboard-1.0.1/src/wmpinboard.c:159:53: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. sizeof(struct { int a, b, c; char d[60]; int e; char f[512]; char g[32]; }); data/wmpinboard-1.0.1/src/wmpinboard.c:159:66: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. sizeof(struct { int a, b, c; char d[60]; int e; char f[512]; char g[32]; }); data/wmpinboard-1.0.1/src/wmpinboard.c:160:58: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const int size_6 = sizeof(struct { int a, b, c; char d[60]; int e; data/wmpinboard-1.0.1/src/wmpinboard.c:161:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char f[512]; char g[32]; time_t h; char i; }); data/wmpinboard-1.0.1/src/wmpinboard.c:161:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char f[512]; char g[32]; time_t h; char i; }); data/wmpinboard-1.0.1/src/wmpinboard.c:164:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char s[STRING_BUF_SIZE]; data/wmpinboard-1.0.1/src/wmpinboard.c:165:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char t[STRING_BUF_SIZE]; data/wmpinboard-1.0.1/src/wmpinboard.c:191:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). file = fopen(s, save ? "wb" : "rb"); data/wmpinboard-1.0.1/src/wmpinboard.c:316:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char s[STRING_BUF_SIZE], *t, *p, *q; data/wmpinboard-1.0.1/src/wmpinboard.c:321:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). file = fopen(filename, "r"); data/wmpinboard-1.0.1/src/wmpinboard.c:372:19: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&label_coords, &coords, sizeof(coords)); data/wmpinboard-1.0.1/src/wmpinboard.c:715:22: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!(file = fopen(opts.theme, "r"))) data/wmpinboard-1.0.1/src/wmpinboard.c:1871:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ch[4]; data/wmpinboard-1.0.1/src/wmpinboard.c:2261:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRING_BUF_SIZE+2]; data/wmpinboard-1.0.1/src/wmpinboard.c:2263:9: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. strcat(buf, " &"); data/wmpinboard-1.0.1/src/wmpinboard.h:72:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char text[10*6]; data/wmpinboard-1.0.1/src/wmpinboard.h:74:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char sketch[(64/8)*64]; /* bitfield; last byte used for other purposes... */ data/wmpinboard-1.0.1/src/wmpinboard.h:75:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char creases[(16/8)*16]; /* lower-res bitfield representing creases */ data/wmpinboard-1.0.1/src/wmpinboard.h:91:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char font[STRING_BUF_SIZE]; /* font descriptor to remember */ data/wmpinboard-1.0.1/src/wmpinboard.h:92:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char theme[STRING_BUF_SIZE]; /* theme file to remember */ data/wmpinboard-1.0.1/src/wmpinboard.h:93:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char alarm_cmd[STRING_BUF_SIZE]; /* alarm command */ data/wmpinboard-1.0.1/src/wmpinboard.h:123:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char a_edit[5]; /* hour, minute, month, day, year being edited */ data/wmpinboard-1.0.1/src/wmpinboard.h:136:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. extern const char c_group[C_NUM]; data/wmpinboard-1.0.1/src/xmisc.c:158:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *p, *s, buf[32], tmp[1024]; data/wmpinboard-1.0.1/src/xmisc.c:184:9: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(buf, "@im="); data/wmpinboard-1.0.1/src/getopt.c:237:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). extern int strlen(const char *); data/wmpinboard-1.0.1/src/getopt.c:402:26: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nonoption_flags_len = strlen(nonoption_flags); data/wmpinboard-1.0.1/src/getopt.c:610:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). == (unsigned int) strlen(p->name)) data/wmpinboard-1.0.1/src/getopt.c:634:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nextchar += strlen(nextchar); data/wmpinboard-1.0.1/src/getopt.c:664:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nextchar += strlen(nextchar); data/wmpinboard-1.0.1/src/getopt.c:680:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nextchar += strlen(nextchar); data/wmpinboard-1.0.1/src/getopt.c:685:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nextchar += strlen(nextchar); data/wmpinboard-1.0.1/src/getopt.c:796:49: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((unsigned int) (nameend - nextchar) == strlen(p->name)) data/wmpinboard-1.0.1/src/getopt.c:819:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nextchar += strlen(nextchar); data/wmpinboard-1.0.1/src/getopt.c:839:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nextchar += strlen(nextchar); data/wmpinboard-1.0.1/src/getopt.c:853:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nextchar += strlen(nextchar); data/wmpinboard-1.0.1/src/getopt.c:857:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nextchar += strlen(nextchar); data/wmpinboard-1.0.1/src/misc.c:78:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). s = smalloc(strlen(getenv("HOME")) + strlen(rc_file_name) + 1); data/wmpinboard-1.0.1/src/misc.c:78:42: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). s = smalloc(strlen(getenv("HOME")) + strlen(rc_file_name) + 1); data/wmpinboard-1.0.1/src/misc.c:108:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). t = smalloc(strlen(s)+1); data/wmpinboard-1.0.1/src/misc.c:110:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i = 0; i+1 < strlen(t); i += 2) { data/wmpinboard-1.0.1/src/notes.c:799:11: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(&ndata[note].text[i], s, 59-i); data/wmpinboard-1.0.1/src/notes.c:802:11: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(&ndata[note].text[i], s, j); data/wmpinboard-1.0.1/src/notes.c:813:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). i = strlen(s); data/wmpinboard-1.0.1/src/notes.c:815:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(&ndata[note].text[offset], s, i); data/wmpinboard-1.0.1/src/notes.c:840:45: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). memset(&ndata[note].text[pos], ' ', pos+strlen(data) > 59 ? 59-pos : data/wmpinboard-1.0.1/src/notes.c:841:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(data)); data/wmpinboard-1.0.1/src/wmpinboard.c:182:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(s, getenv("HOME"), sizeof(s)); data/wmpinboard-1.0.1/src/wmpinboard.c:183:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (sizeof(s)-strlen(s)-1 < strlen(rc_file_name)+strlen(ext)) data/wmpinboard-1.0.1/src/wmpinboard.c:183:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (sizeof(s)-strlen(s)-1 < strlen(rc_file_name)+strlen(ext)) data/wmpinboard-1.0.1/src/wmpinboard.c:183:52: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (sizeof(s)-strlen(s)-1 < strlen(rc_file_name)+strlen(ext)) data/wmpinboard-1.0.1/src/wmpinboard.c:248:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(opts.font) && opts.font[strlen(opts.font)-1] == '\n') data/wmpinboard-1.0.1/src/wmpinboard.c:248:40: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(opts.font) && opts.font[strlen(opts.font)-1] == '\n') data/wmpinboard-1.0.1/src/wmpinboard.c:249:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). opts.font[strlen(opts.font)-1] = '\0'; data/wmpinboard-1.0.1/src/wmpinboard.c:253:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(opts.theme) && opts.theme[strlen(opts.theme)-1] == '\n') data/wmpinboard-1.0.1/src/wmpinboard.c:253:44: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(opts.theme) && opts.theme[strlen(opts.theme)-1] == '\n') data/wmpinboard-1.0.1/src/wmpinboard.c:254:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). opts.theme[strlen(opts.theme)-1] = '\0'; data/wmpinboard-1.0.1/src/wmpinboard.c:258:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(opts.alarm_cmd) && opts.alarm_cmd[strlen(opts.alarm_cmd)-1] == data/wmpinboard-1.0.1/src/wmpinboard.c:258:52: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(opts.alarm_cmd) && opts.alarm_cmd[strlen(opts.alarm_cmd)-1] == data/wmpinboard-1.0.1/src/wmpinboard.c:261:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). opts.alarm_cmd[strlen(opts.alarm_cmd)-1] = '\0'; data/wmpinboard-1.0.1/src/wmpinboard.c:311:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(filename)) data/wmpinboard-1.0.1/src/wmpinboard.c:320:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!strlen(filename)) return; data/wmpinboard-1.0.1/src/wmpinboard.c:342:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (s[strlen(s)-1] == '\n') s[strlen(s)-1] = '\0'; data/wmpinboard-1.0.1/src/wmpinboard.c:342:33: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (s[strlen(s)-1] == '\n') s[strlen(s)-1] = '\0'; data/wmpinboard-1.0.1/src/wmpinboard.c:390:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(s) && s[strlen(s)-1] == '\n') s[strlen(s)-1] = '\0'; data/wmpinboard-1.0.1/src/wmpinboard.c:390:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(s) && s[strlen(s)-1] == '\n') s[strlen(s)-1] = '\0'; data/wmpinboard-1.0.1/src/wmpinboard.c:390:48: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(s) && s[strlen(s)-1] == '\n') s[strlen(s)-1] = '\0'; data/wmpinboard-1.0.1/src/wmpinboard.c:391:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). } while (!eof && strlen(s)); data/wmpinboard-1.0.1/src/wmpinboard.c:401:56: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (p = t; !(eof = !fgets(s, sizeof(s), file)) && strlen(s) && *s != '\n';) data/wmpinboard-1.0.1/src/wmpinboard.c:404:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(s); data/wmpinboard-1.0.1/src/wmpinboard.c:616:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(opts.font, name, sizeof(opts.font)); data/wmpinboard-1.0.1/src/wmpinboard.c:692:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(data) >= sizeof(opts.font)) { data/wmpinboard-1.0.1/src/wmpinboard.c:705:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!strlen(data) || !strcasecmp(data, "default")) { data/wmpinboard-1.0.1/src/wmpinboard.c:709:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(data) >= sizeof(opts.theme)) { data/wmpinboard-1.0.1/src/wmpinboard.c:724:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!strlen(data)) { data/wmpinboard-1.0.1/src/wmpinboard.c:728:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(data) >= sizeof(opts.alarm_cmd)) { data/wmpinboard-1.0.1/src/wmpinboard.c:777:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). else if (strlen(s) >= 2 && *s == '%') { /* color/position code given */ data/wmpinboard-1.0.1/src/wmpinboard.c:798:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!strlen(s)) die("Won't add blank note."); data/wmpinboard-1.0.1/src/wmpinboard.c:830:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(opts.font) ? opts.font : fonts[0].font, data/wmpinboard-1.0.1/src/wmpinboard.c:831:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(opts.theme) ? opts.theme : "[default]", data/wmpinboard-1.0.1/src/wmpinboard.c:832:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(opts.alarm_cmd) ? opts.alarm_cmd : "[none]"); data/wmpinboard-1.0.1/src/wmpinboard.c:951:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). opts.display = smalloc(strlen(optarg)+1); data/wmpinboard-1.0.1/src/wmpinboard.c:2137:3: [1] (access) umask: Ensure that umask is given most restrictive possible setting (e.g., 066 or 077) (CWE-732). umask(077); /* users' notes needn't be world-readable */ data/wmpinboard-1.0.1/src/wmpinboard.c:2260:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(opts.alarm_cmd)) { data/wmpinboard-1.0.1/src/wmpinboard.c:2276:20: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. case M_NOOP: usleep(100000L); break; data/wmpinboard-1.0.1/src/wmpinboard.c:2277:20: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. case M_ALRM: usleep(500000L); break; /* animation timing, 0.5s */ data/wmpinboard-1.0.1/src/wmpinboard.c:2278:20: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. default: usleep( 10000L); data/wmpinboard-1.0.1/src/xmisc.c:299:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). l = len < 0 ? strlen(text) : len; data/wmpinboard-1.0.1/src/xmisc.c:301:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy((char *)cb_buffer, text, l); data/wmpinboard-1.0.1/src/xmisc.c:342:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). 8, PropModeReplace, cb_buffer, strlen((char*) cb_buffer)); ANALYSIS SUMMARY: Hits = 156 Lines analyzed = 5880 in approximately 0.20 seconds (29752 lines/second) Physical Source Lines of Code (SLOC) = 4416 Hits@level = [0] 80 [1] 65 [2] 49 [3] 18 [4] 24 [5] 0 Hits@level+ = [0+] 236 [1+] 156 [2+] 91 [3+] 42 [4+] 24 [5+] 0 Hits/KSLOC@level+ = [0+] 53.442 [1+] 35.3261 [2+] 20.6069 [3+] 9.51087 [4+] 5.43478 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.