Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/xdg-dbus-proxy-0.1.2/tests/test-proxy.c Examining data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c Examining data/xdg-dbus-proxy-0.1.2/flatpak-proxy.h Examining data/xdg-dbus-proxy-0.1.2/dbus-proxy.c Examining data/xdg-dbus-proxy-0.1.2/backport-autoptr.h FINAL RESULTS: data/xdg-dbus-proxy-0.1.2/dbus-proxy.c:226:33: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. if (*args_i >= args->len || ((char *) g_ptr_array_index (args, *args_i))[0] == '-') data/xdg-dbus-proxy-0.1.2/dbus-proxy.c:235:33: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. if (*args_i >= args->len || ((char *) g_ptr_array_index (args, *args_i))[0] == '-') data/xdg-dbus-proxy-0.1.2/dbus-proxy.c:376:39: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. g_ptr_array_add (args, g_strdup ((char *) argv[i])); data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c:762:7: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (buffer->data, old->data, old->size); data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c:832:7: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (&buffer->data[buffer->pos], extra_bytes, res); data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c:1549:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (buffer->data, blob, blob_size); data/xdg-dbus-proxy-0.1.2/dbus-proxy.c:96:22: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). bytes_read = read (fd, buf + buf_size, readlen); data/xdg-dbus-proxy-0.1.2/dbus-proxy.c:166:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). const char *fd_s = arg + strlen ("--fd="); data/xdg-dbus-proxy-0.1.2/dbus-proxy.c:184:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). const char *fd_s = arg + strlen ("--args="); data/xdg-dbus-proxy-0.1.2/dbus-proxy.c:268:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). name[strlen (name) - 2] = 0; data/xdg-dbus-proxy-0.1.2/dbus-proxy.c:302:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). name[strlen (name) - 2] = 0; data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c:539:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). filter->path[strlen (filter->path) - 2] = 0; data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c:546:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). method_end = rule + strlen (rule); data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c:588:35: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). gsize filter_path_len = strlen (filter->path); data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c:2542:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). next_char = line[strlen (AUTH_BEGIN)]; data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c:2564:46: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). AUTH_LINE_SENTINEL, strlen (AUTH_LINE_SENTINEL)); data/xdg-dbus-proxy-0.1.2/flatpak-proxy.c:2567:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). offset = (line_end + strlen (AUTH_LINE_SENTINEL) - line_start); data/xdg-dbus-proxy-0.1.2/tests/test-proxy.c:85:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen (address_buffer) >= sizeof (address_buffer) - 1) data/xdg-dbus-proxy-0.1.2/tests/test-proxy.c:91:45: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). address_buffer + strlen (address_buffer), data/xdg-dbus-proxy-0.1.2/tests/test-proxy.c:92:54: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). sizeof (address_buffer) - strlen (address_buffer), data/xdg-dbus-proxy-0.1.2/tests/test-proxy.c:159:16: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). bytes_read = read (sync_pipe[READ_END], &buf, 1); ANALYSIS SUMMARY: Hits = 21 Lines analyzed = 3835 in approximately 0.09 seconds (43442 lines/second) Physical Source Lines of Code (SLOC) = 2817 Hits@level = [0] 2 [1] 15 [2] 6 [3] 0 [4] 0 [5] 0 Hits@level+ = [0+] 23 [1+] 21 [2+] 6 [3+] 0 [4+] 0 [5+] 0 Hits/KSLOC@level+ = [0+] 8.16471 [1+] 7.45474 [2+] 2.12993 [3+] 0 [4+] 0 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.