Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/xfce4-places-plugin-1.8.1/panel-plugin/places.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/cfg.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.h Examining data/xfce4-places-plugin-1.8.1/panel-plugin/view.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model.h Examining data/xfce4-places-plugin-1.8.1/panel-plugin/button.h Examining data/xfce4-places-plugin-1.8.1/panel-plugin/support.h Examining data/xfce4-places-plugin-1.8.1/panel-plugin/view.h Examining data/xfce4-places-plugin-1.8.1/panel-plugin/cfg.h Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model_volumes_notify.h Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model_volumes.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model_volumes_notify.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model_user.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model_user.h Examining data/xfce4-places-plugin-1.8.1/panel-plugin/model_volumes.h Examining data/xfce4-places-plugin-1.8.1/panel-plugin/button.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/support.c Examining data/xfce4-places-plugin-1.8.1/panel-plugin/places.h FINAL RESULTS: data/xfce4-places-plugin-1.8.1/panel-plugin/model_user.c:140:45: [3] (buffer) g_get_home_dir: This function is synonymous with 'getenv("HOME")';it returns untrustable input if the environment can beset by an attacker. It can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. legacy_filename = g_build_filename (g_get_home_dir (), ".gtk-bookmarks", NULL); data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c:126:27: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). PlacesBookmarkAction *open, *terminal; data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c:145:66: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->actions = g_list_prepend(bookmark->actions, open); data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c:146:32: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->primary_action = open; data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c:173:66: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->actions = g_list_prepend(bookmark->actions, open); data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c:174:32: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->primary_action = open; data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c:195:70: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->actions = g_list_prepend(bookmark->actions, open); data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c:196:36: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->primary_action = open; data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c:209:66: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->actions = g_list_prepend(bookmark->actions, open); data/xfce4-places-plugin-1.8.1/panel-plugin/model_system.c:210:32: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->primary_action = open; data/xfce4-places-plugin-1.8.1/panel-plugin/model_user.c:134:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(pbg_priv(bookmark_group)->filename, "r"); data/xfce4-places-plugin-1.8.1/panel-plugin/model_user.c:141:14: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(legacy_filename, "r"); data/xfce4-places-plugin-1.8.1/panel-plugin/model_user.c:296:27: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). PlacesBookmarkAction *open, *terminal; data/xfce4-places-plugin-1.8.1/panel-plugin/model_user.c:327:68: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). clone->actions = g_list_prepend(clone->actions, open); data/xfce4-places-plugin-1.8.1/panel-plugin/model_user.c:328:37: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). clone->primary_action = open; data/xfce4-places-plugin-1.8.1/panel-plugin/model_volumes.c:453:47: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). PlacesBookmarkAction *action, *terminal, *open; data/xfce4-places-plugin-1.8.1/panel-plugin/model_volumes.c:503:78: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->actions = g_list_prepend(bookmark->actions, open); data/xfce4-places-plugin-1.8.1/panel-plugin/model_volumes.c:504:44: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bookmark->primary_action = open; data/xfce4-places-plugin-1.8.1/panel-plugin/model_user.c:228:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p = parse_name + strlen (scheme); ANALYSIS SUMMARY: Hits = 19 Lines analyzed = 4722 in approximately 0.11 seconds (41210 lines/second) Physical Source Lines of Code (SLOC) = 3079 Hits@level = [0] 0 [1] 1 [2] 17 [3] 1 [4] 0 [5] 0 Hits@level+ = [0+] 19 [1+] 19 [2+] 18 [3+] 1 [4+] 0 [5+] 0 Hits/KSLOC@level+ = [0+] 6.17083 [1+] 6.17083 [2+] 5.84605 [3+] 0.324781 [4+] 0 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.