Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-regex.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-window-dropdown.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-image-loader.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-gdbus.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-encoding-action.h
Examining data/xfce4-terminal-0.8.9.2/terminal/main.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-options.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-window-ui.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-widget.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-widget.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-gdbus.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-image-loader.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-window.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-enum-types.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-preferences-dialog.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-util.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-preferences-dialog.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-marshal.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-app.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-app.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-search-dialog.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-options.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-search-dialog.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-preferences.c
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-preferences.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-marshal.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-util.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-window.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-enum-types.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-window-dropdown.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-private.h
Examining data/xfce4-terminal-0.8.9.2/terminal/terminal-encoding-action.c
FINAL RESULTS:
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:2338:16: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
length = readlink (file, buffer, sizeof (buffer) - 1);
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:725:27: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access (shells [i], X_OK) == 0)
data/xfce4-terminal-0.8.9.2/terminal/terminal-window.c:511:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (ui_new, p2);
data/xfce4-terminal-0.8.9.2/terminal/terminal-app.c:406:82: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
new_role = g_strdup_printf ("%s-%u-%u", PACKAGE_NAME, (guint) time (NULL), g_random_int ());
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:1105:26: [3] (random) g_random_double_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
hsv[HSV_HUE] = g_random_double_range (0.00, 1.00);
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:1124:33: [3] (random) g_random_double_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
hsv[HSV_SATURATION] = g_random_double_range (sat_min, sat_max);
data/xfce4-terminal-0.8.9.2/terminal/terminal-window.c:507:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (ui_new, terminal_window_ui, p1 - terminal_window_ui);
data/xfce4-terminal-0.8.9.2/terminal/terminal-window.c:508:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat (ui_new, "<menuitem action=\"copy-html\"/>");
data/xfce4-terminal-0.8.9.2/terminal/terminal-window.c:509:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (ui_new + strlen (ui_new), p1, p2 - p1);
data/xfce4-terminal-0.8.9.2/terminal/terminal-window.c:510:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat (ui_new, "<menuitem action=\"copy-html\"/>");
data/xfce4-terminal-0.8.9.2/terminal/terminal-app.c:648:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (other_name, name, strlen (name)) == 0)
data/xfce4-terminal-0.8.9.2/terminal/terminal-options.c:71:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen (long_name);
data/xfce4-terminal-0.8.9.2/terminal/terminal-options.c:110:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t pref_len = strlen ("--show-");
data/xfce4-terminal-0.8.9.2/terminal/terminal-preferences.c:1354:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
option = g_new (gchar, strlen (name) + 1);
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:610:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp ("background-", name, strlen ("background-")) == 0)
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:622:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
else if (strncmp ("color-", name, strlen ("color-")) == 0)
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:624:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
else if (strncmp ("font-", name, strlen ("font-")) == 0)
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:626:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
else if (strncmp ("misc-bell", name, strlen ("misc-bell")) == 0)
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:646:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
else if (strncmp ("title-", name, strlen ("title-")) == 0)
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:1816:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i = 0; i < strlen (res_text); ++i)
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:1820:79: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vte_terminal_feed_child (VTE_TERMINAL (screen->terminal), res_text, strlen (res_text));
data/xfce4-terminal-0.8.9.2/terminal/terminal-screen.c:2984:67: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vte_terminal_feed_child (VTE_TERMINAL (screen->terminal), text, strlen (text));
data/xfce4-terminal-0.8.9.2/terminal/terminal-widget.c:245:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
modified_wlink = g_strdup (wlink + strlen (MAILTO));
data/xfce4-terminal-0.8.9.2/terminal/terminal-widget.c:495:67: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vte_terminal_feed_child (VTE_TERMINAL (widget), text, strlen (text));
data/xfce4-terminal-0.8.9.2/terminal/terminal-widget.c:531:73: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vte_terminal_feed_child (VTE_TERMINAL (widget), filename, strlen (filename));
data/xfce4-terminal-0.8.9.2/terminal/terminal-widget.c:573:65: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vte_terminal_feed_child (VTE_TERMINAL (widget), text, strlen (text));
data/xfce4-terminal-0.8.9.2/terminal/terminal-widget.c:700:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
uri = strncmp (wlink, MAILTO, strlen (MAILTO)) == 0
data/xfce4-terminal-0.8.9.2/terminal/terminal-window.c:505:62: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const guint length_new = terminal_window_ui_length + 2 * strlen ("<menuitem action=\"copy-html\"/>");
data/xfce4-terminal-0.8.9.2/terminal/terminal-window.c:509:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memcpy (ui_new + strlen (ui_new), p1, p2 - p1);
ANALYSIS SUMMARY:
Hits = 29
Lines analyzed = 16601 in approximately 0.34 seconds (48779 lines/second)
Physical Source Lines of Code (SLOC) = 11659
Hits@level = [0] 0 [1] 19 [2] 4 [3] 3 [4] 2 [5] 1
Hits@level+ = [0+] 29 [1+] 29 [2+] 10 [3+] 6 [4+] 3 [5+] 1
Hits/KSLOC@level+ = [0+] 2.48735 [1+] 2.48735 [2+] 0.857706 [3+] 0.514624 [4+] 0.257312 [5+] 0.0857706
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.