Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/xsecurelock-1.5.1/env_info.h
Examining data/xsecurelock-1.5.1/version.c
Examining data/xsecurelock-1.5.1/helpers/monitors.c
Examining data/xsecurelock-1.5.1/helpers/dimmer.c
Examining data/xsecurelock-1.5.1/helpers/until_nonidle.c
Examining data/xsecurelock-1.5.1/helpers/authproto.c
Examining data/xsecurelock-1.5.1/helpers/authproto.h
Examining data/xsecurelock-1.5.1/helpers/auth_x11.c
Examining data/xsecurelock-1.5.1/helpers/saver_multiplex.c
Examining data/xsecurelock-1.5.1/helpers/authproto_pam.c
Examining data/xsecurelock-1.5.1/helpers/pgrp_placeholder.c
Examining data/xsecurelock-1.5.1/helpers/monitors.h
Examining data/xsecurelock-1.5.1/saver_child.h
Examining data/xsecurelock-1.5.1/env_settings.h
Examining data/xsecurelock-1.5.1/xscreensaver_api.h
Examining data/xsecurelock-1.5.1/env_settings.c
Examining data/xsecurelock-1.5.1/util.h
Examining data/xsecurelock-1.5.1/logging.c
Examining data/xsecurelock-1.5.1/util.c
Examining data/xsecurelock-1.5.1/wait_pgrp.h
Examining data/xsecurelock-1.5.1/test/remap_all.c
Examining data/xsecurelock-1.5.1/test/nvidia_break_compositor.c
Examining data/xsecurelock-1.5.1/test/cat_authproto.c
Examining data/xsecurelock-1.5.1/test/get_compositor.c
Examining data/xsecurelock-1.5.1/main.c
Examining data/xsecurelock-1.5.1/unmap_all.h
Examining data/xsecurelock-1.5.1/auth_child.h
Examining data/xsecurelock-1.5.1/wait_pgrp.c
Examining data/xsecurelock-1.5.1/saver_child.c
Examining data/xsecurelock-1.5.1/wm_properties.c
Examining data/xsecurelock-1.5.1/unmap_all.c
Examining data/xsecurelock-1.5.1/wm_properties.h
Examining data/xsecurelock-1.5.1/version.h
Examining data/xsecurelock-1.5.1/env_info.c
Examining data/xsecurelock-1.5.1/auth_child.c
Examining data/xsecurelock-1.5.1/logging.h
Examining data/xsecurelock-1.5.1/mlock_page.h
Examining data/xsecurelock-1.5.1/xscreensaver_api.c
FINAL RESULTS:
data/xsecurelock-1.5.1/env_settings.c:132:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(value, X_OK)) {
data/xsecurelock-1.5.1/helpers/auth_x11.c:1139:15: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(priv.displaybuf, DISPLAYBUF_SIZE,
data/xsecurelock-1.5.1/helpers/auth_x11.c:1144:15: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(priv.displaybuf, DISPLAYBUF_SIZE, "%#" PRIx64,
data/xsecurelock-1.5.1/helpers/until_nonidle.c:192:5: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(argv[1], argv + 1);
data/xsecurelock-1.5.1/logging.c:24:3: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, args);
data/xsecurelock-1.5.1/logging.c:34:3: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, args);
data/xsecurelock-1.5.1/logging.h:26:57: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
void Log(const char *format, ...) __attribute__((format(printf, 1, 2)));
data/xsecurelock-1.5.1/logging.h:35:62: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
void LogErrno(const char *format, ...) __attribute__((format(printf, 1, 2)));
data/xsecurelock-1.5.1/main.c:507:3: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(buf);
data/xsecurelock-1.5.1/main.c:666:7: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(notify_command[0], notify_command);
data/xsecurelock-1.5.1/main.c:752:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(HELPER_PATH "/", X_OK)) {
data/xsecurelock-1.5.1/main.c:1280:13: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system("eval \"$XSECURELOCK_SWITCH_USER_COMMAND\" &");
data/xsecurelock-1.5.1/main.c:1311:21: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(buf);
data/xsecurelock-1.5.1/test/get_compositor.c:20:3: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(buf);
data/xsecurelock-1.5.1/test/get_compositor.c:24:3: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(buf);
data/xsecurelock-1.5.1/test/get_compositor.c:31:3: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(buf);
data/xsecurelock-1.5.1/test/get_compositor.c:40:5: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(buf);
data/xsecurelock-1.5.1/wait_pgrp.c:124:3: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(path, (char *const *)argv);
data/xsecurelock-1.5.1/env_settings.c:29:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* value = getenv(name);
data/xsecurelock-1.5.1/env_settings.c:48:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* value = getenv(name);
data/xsecurelock-1.5.1/env_settings.c:77:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* value = getenv(name);
data/xsecurelock-1.5.1/env_settings.c:96:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* value = getenv(name);
data/xsecurelock-1.5.1/env_settings.c:105:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* value = getenv(name);
data/xsecurelock-1.5.1/helpers/auth_x11.c:1501:3: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(tv.tv_sec ^ tv.tv_usec ^ getpid());
data/xsecurelock-1.5.1/helpers/authproto_pam.c:184:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *display = getenv("DISPLAY");
data/xsecurelock-1.5.1/auth_child.c:138:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *args[2] = {executable, NULL};
data/xsecurelock-1.5.1/helpers/auth_x11.c:194:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[256];
data/xsecurelock-1.5.1/helpers/auth_x11.c:197:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char username[256];
data/xsecurelock-1.5.1/helpers/auth_x11.c:378:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[128];
data/xsecurelock-1.5.1/helpers/auth_x11.c:435:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, word, n);
data/xsecurelock-1.5.1/helpers/auth_x11.c:452:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, layout, n);
data/xsecurelock-1.5.1/helpers/auth_x11.c:472:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, ", ", 2);
data/xsecurelock-1.5.1/helpers/auth_x11.c:482:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, name, n);
data/xsecurelock-1.5.1/helpers/auth_x11.c:739:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(*output, input, input_size);
data/xsecurelock-1.5.1/helpers/auth_x11.c:782:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char full_title[256];
data/xsecurelock-1.5.1/helpers/auth_x11.c:812:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char datetime[80] = "";
data/xsecurelock-1.5.1/helpers/auth_x11.c:1002:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pwbuf[PWBUF_SIZE];
data/xsecurelock-1.5.1/helpers/auth_x11.c:1008:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char displaybuf[DISPLAYBUF_SIZE];
data/xsecurelock-1.5.1/helpers/auth_x11.c:1053:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(priv.displaybuf, priv.pwbuf, priv.pwlen);
data/xsecurelock-1.5.1/helpers/auth_x11.c:1102:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(priv.displaybuf + i * stride, disco_combiner,
data/xsecurelock-1.5.1/helpers/auth_x11.c:1104:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(priv.displaybuf + i * stride + combiner_length, dancer,
data/xsecurelock-1.5.1/helpers/auth_x11.c:1107:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(priv.displaybuf + DISCO_PASSWORD_DANCERS * stride,
data/xsecurelock-1.5.1/helpers/auth_x11.c:1276:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(*response, priv.pwbuf, priv.pwlen);
data/xsecurelock-1.5.1/helpers/auth_x11.c:1388:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *args[2] = {authproto_executable, NULL};
data/xsecurelock-1.5.1/helpers/authproto.c:59:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char prefix[16];
data/xsecurelock-1.5.1/helpers/authproto_pam.c:157:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char username[256];
data/xsecurelock-1.5.1/helpers/dimmer.c:77:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[64];
data/xsecurelock-1.5.1/helpers/until_nonidle.c:114:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char this_timer[64];
data/xsecurelock-1.5.1/helpers/until_nonidle.c:116:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(this_timer, timers, len);
data/xsecurelock-1.5.1/logging.c:13:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[32];
data/xsecurelock-1.5.1/main.c:121:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[16];
data/xsecurelock-1.5.1/main.c:342:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/xsecurelock-1.5.1/main.c:497:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/xsecurelock-1.5.1/main.c:1297:15: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[64];
data/xsecurelock-1.5.1/test/get_compositor.c:14:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/xsecurelock-1.5.1/test/get_compositor.c:50:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[64];
data/xsecurelock-1.5.1/wait_pgrp.c:108:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *args[2] = {"prgp_placeholder", NULL};
data/xsecurelock-1.5.1/xscreensaver_api.c:27:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char window_id_str[32];
data/xsecurelock-1.5.1/auth_child.c:167:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ssize_t to_write = (ssize_t)strlen(stdinbuf);
data/xsecurelock-1.5.1/env_info.c:45:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(pwd->pw_name) >= username_buflen) {
data/xsecurelock-1.5.1/env_info.c:46:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Log("Username too long: got %d, want < %d", (int)strlen(pwd->pw_name),
data/xsecurelock-1.5.1/env_info.c:51:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(username_buf, pwd->pw_name, username_buflen);
data/xsecurelock-1.5.1/helpers/auth_x11.c:429:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t n = strlen(word);
data/xsecurelock-1.5.1/helpers/auth_x11.c:445:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = strlen(layout);
data/xsecurelock-1.5.1/helpers/auth_x11.c:476:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t n = strlen(name);
data/xsecurelock-1.5.1/helpers/auth_x11.c:746:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t username_len = strlen(username);
data/xsecurelock-1.5.1/helpers/auth_x11.c:756:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
show_hostname > 1 ? strlen(hostname) : strcspn(hostname, ".");
data/xsecurelock-1.5.1/helpers/auth_x11.c:768:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(output, input, output_size - 1);
data/xsecurelock-1.5.1/helpers/auth_x11.c:788:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len_full_title = strlen(full_title);
data/xsecurelock-1.5.1/helpers/auth_x11.c:791:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len_str = strlen(str);
data/xsecurelock-1.5.1/helpers/auth_x11.c:798:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len_indicators = strlen(indicators);
data/xsecurelock-1.5.1/helpers/auth_x11.c:803:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len_switch_layout = strlen(switch_layout);
data/xsecurelock-1.5.1/helpers/auth_x11.c:809:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len_switch_user = strlen(switch_user);
data/xsecurelock-1.5.1/helpers/auth_x11.c:829:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len_datetime = strlen(datetime);
data/xsecurelock-1.5.1/helpers/auth_x11.c:981:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(displaybuf, selection, displaybufsize);
data/xsecurelock-1.5.1/helpers/auth_x11.c:983:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*displaylen = strlen(selection);
data/xsecurelock-1.5.1/helpers/auth_x11.c:1091:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t combiner_length = strlen(disco_combiner);
data/xsecurelock-1.5.1/helpers/auth_x11.c:1092:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t dancer_length = strlen(disco_dancers[0]);
data/xsecurelock-1.5.1/helpers/auth_x11.c:1095:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
stride * DISCO_PASSWORD_DANCERS * strlen(disco_dancers[0]) +
data/xsecurelock-1.5.1/helpers/auth_x11.c:1096:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(disco_combiner);
data/xsecurelock-1.5.1/helpers/auth_x11.c:1135:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(priv.displaybuf, "----", DISPLAYBUF_SIZE - 1);
data/xsecurelock-1.5.1/helpers/auth_x11.c:1213:23: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t nread = read(0, &priv.inputbuf, 1);
data/xsecurelock-1.5.1/helpers/auth_x11.c:1405:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
explicit_bzero(message, strlen(message));
data/xsecurelock-1.5.1/helpers/auth_x11.c:1412:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
explicit_bzero(message, strlen(message));
data/xsecurelock-1.5.1/helpers/auth_x11.c:1420:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
explicit_bzero(response, strlen(response));
data/xsecurelock-1.5.1/helpers/auth_x11.c:1425:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
explicit_bzero(message, strlen(message));
data/xsecurelock-1.5.1/helpers/auth_x11.c:1432:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
explicit_bzero(response, strlen(response));
data/xsecurelock-1.5.1/helpers/auth_x11.c:1437:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
explicit_bzero(message, strlen(message));
data/xsecurelock-1.5.1/helpers/auth_x11.c:1445:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
explicit_bzero(message, strlen(message));
data/xsecurelock-1.5.1/helpers/authproto.c:49:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len_s = strlen(message);
data/xsecurelock-1.5.1/helpers/authproto.c:81:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t got = read(fd, buf + total, n - total);
data/xsecurelock-1.5.1/helpers/authproto_pam.c:93:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
explicit_bzero((*resp)[i].resp, strlen((*resp)[i].resp));
ANALYSIS SUMMARY:
Hits = 92
Lines analyzed = 6540 in approximately 0.19 seconds (35345 lines/second)
Physical Source Lines of Code (SLOC) = 4343
Hits@level = [0] 26 [1] 34 [2] 33 [3] 7 [4] 18 [5] 0
Hits@level+ = [0+] 118 [1+] 92 [2+] 58 [3+] 25 [4+] 18 [5+] 0
Hits/KSLOC@level+ = [0+] 27.1702 [1+] 21.1835 [2+] 13.3548 [3+] 5.75639 [4+] 4.1446 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.