Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/yabar-0.4.0/include/yabar.h
Examining data/yabar-0.4.0/src/intern_blks/ya_intern.c
Examining data/yabar-0.4.0/src/ya_draw.c
Examining data/yabar-0.4.0/src/ya_exec.c
Examining data/yabar-0.4.0/src/ya_main.c
Examining data/yabar-0.4.0/src/ya_parse.c
FINAL RESULTS:
data/yabar-0.4.0/src/intern_blks/ya_intern.c:45:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(blk->buf, blk->internal->prefix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:67:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(blk->buf, blk->internal->suffix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:91:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(blk->buf, blk->internal->suffix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:158:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(blk->buf, blk->internal->suffix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:188:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(blk->buf, blk->internal->suffix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:209:3: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(blk->internal->option[1], "%s %s", dnstr, upstr);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:254:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(startstr, "%s%u%c %s%u%c", dnstr, rxrate, rxc, upstr, txrate, txc);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:256:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(blk->buf, blk->internal->suffix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:298:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(blk->buf, blk->internal->suffix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:322:6: [4] (buffer) fscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
if(fscanf(tfile,"%s %Lf %Lf %Lf %Lf",cpustr, &old[0],&old[1],&old[2],&old[3])!=5)
data/yabar-0.4.0/src/intern_blks/ya_intern.c:329:6: [4] (buffer) fscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
if(fscanf(tfile,"%s %Lf %Lf %Lf %Lf", cpustr, &cur[0],&cur[1],&cur[2],&cur[3])!=5)
data/yabar-0.4.0/src/intern_blks/ya_intern.c:337:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(blk->buf, blk->internal->suffix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:357:3: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(blk->internal->option[1], "%s %s", dnstr, upstr);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:388:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(startstr, "%s%lu%c %s%lu%c", dnstr, drd, crd, upstr, dwr, cwr);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:392:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(blk->buf, blk->internal->suffix);
data/yabar-0.4.0/src/ya_draw.c:268:6: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl("/bin/sh", "/bin/sh", "-c", curbar->button_cmd[eb->detail-1], (char *) NULL);
data/yabar-0.4.0/src/ya_exec.c:76:3: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(yashell, yashell, "-c", blk->cmd, (char *) NULL);
data/yabar-0.4.0/src/ya_exec.c:106:4: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(yashell, yashell, "-c", blk->cmd, (char *) NULL);
data/yabar-0.4.0/src/ya_exec.c:139:3: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(yashell, yashell, "-c", blk->cmd, (char *) NULL);
data/yabar-0.4.0/src/ya_exec.c:400:3: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(yashell, yashell, "-c", blk->button_cmd[eb->detail-1], (char *) NULL);
data/yabar-0.4.0/src/ya_exec.c:288:16: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((opt = getopt(argc, argv, "cvh")) != (char)-1) {
data/yabar-0.4.0/src/ya_parse.c:621:31: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char * const envhome = getenv("HOME");
data/yabar-0.4.0/include/yabar.h:141:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[CMONLEN];
data/yabar-0.4.0/include/yabar.h:152:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *button_cmd[5];
data/yabar-0.4.0/include/yabar.h:191:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *option[3];
data/yabar-0.4.0/include/yabar.h:198:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *button_cmd[5];
data/yabar-0.4.0/include/yabar.h:260:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char conf_file[CFILELEN];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:89:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(startstr, "%ld:%02d", hr, min);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:112:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fpath[128];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:127:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen(fpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:137:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen(fpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:156:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(startstr, "%d", temp);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:172:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fpath[128];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:174:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen(fpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:183:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen(fpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:186:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(startstr, "%d", bright);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:199:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rxpath[128];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:200:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char txpath[128];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:204:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dnstr[20], upstr[20];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:211:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
rxfile = fopen(rxpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:212:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
txfile = fopen(txpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:230:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
rxfile = fopen(rxpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:231:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
txfile = fopen(txpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:269:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tline[50];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:274:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen("/proc/meminfo", "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:283:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen("/proc/meminfo", "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:296:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(startstr, "%.1f%c", used, unit);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:312:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cpustr[20];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:314:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen(fpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:328:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen(fpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:335:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(startstr, "%.1Lf", ya_avg);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:351:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tpath[100];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:354:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dnstr[20], upstr[20];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:360:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen(tpath, "r");
data/yabar-0.4.0/src/intern_blks/ya_intern.c:374:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tfile = fopen(tpath, "r");
data/yabar-0.4.0/src/ya_exec.c:11:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char conf_file[CFILELEN];
data/yabar-0.4.0/src/ya_exec.c:37:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(blk->buf, "%u", cur_desktop+1);
data/yabar-0.4.0/src/ya_exec.c:52:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(blk->buf, "%u", current_desktop+1);
data/yabar-0.4.0/src/ya_exec.c:386:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char blkx[6], blky[6], blkw[6];
data/yabar-0.4.0/src/intern_blks/ya_intern.c:43:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*prflen = strlen(blk->internal->prefix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:50:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*suflen = strlen(blk->internal->suffix);
data/yabar-0.4.0/src/intern_blks/ya_intern.c:130:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:130:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:177:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:177:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:215:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:215:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:277:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:277:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:317:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:317:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:363:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/intern_blks/ya_intern.c:363:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(blk->buf, "BLOCK ERROR!", strlen("BLOCK ERROR!"));
data/yabar-0.4.0/src/ya_draw.c:39:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
atom_cookie[i] = xcb_intern_atom(ya.c, 0, strlen(atom_names[i]), atom_names[i]);
data/yabar-0.4.0/src/ya_draw.c:70:99: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
xcb_change_property(ya.c, XCB_PROP_MODE_REPLACE, bar->win, XCB_ATOM_WM_NAME, XCB_ATOM_STRING, 8, strlen("yabar"), "yabar");
data/yabar-0.4.0/src/ya_draw.c:194:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pango_layout_set_text(layout, blk->strbuf, strlen(blk->strbuf));
data/yabar-0.4.0/src/ya_draw.c:196:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pango_layout_set_markup(layout, blk->strbuf, strlen(blk->strbuf));
data/yabar-0.4.0/src/ya_draw.c:199:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pango_layout_set_text(layout, blk->buf, strlen(blk->buf));
data/yabar-0.4.0/src/ya_draw.c:201:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pango_layout_set_markup(layout, blk->buf, strlen(blk->buf));
data/yabar-0.4.0/src/ya_draw.c:342:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(blk->buf, reply.strings, reply.strings_len);
data/yabar-0.4.0/src/ya_exec.c:80:21: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t read_ret = read(opipe[0], blk->buf, blk->bufsize);
data/yabar-0.4.0/src/ya_exec.c:112:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t read_ret = read(opipe[0], blk->buf, blk->bufsize);
data/yabar-0.4.0/src/ya_exec.c:147:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read_ret = read(opipe[0], blk->buf, blk->bufsize);
data/yabar-0.4.0/src/ya_exec.c:231:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(conf_file, cpath, CFILELEN);
data/yabar-0.4.0/src/ya_exec.c:272:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tmpmon->name, tname, tname_len);
data/yabar-0.4.0/src/ya_parse.c:113:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int nlen = strlen(name);
data/yabar-0.4.0/src/ya_parse.c:134:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(barname, name, barnamelen-1);
data/yabar-0.4.0/src/ya_parse.c:136:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(blkname, name, blknamelen);
data/yabar-0.4.0/src/ya_parse.c:422:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
else if(strlen(retstr) < 1) {
ANALYSIS SUMMARY:
Hits = 89
Lines analyzed = 2256 in approximately 0.08 seconds (28950 lines/second)
Physical Source Lines of Code (SLOC) = 1951
Hits@level = [0] 70 [1] 30 [2] 37 [3] 2 [4] 20 [5] 0
Hits@level+ = [0+] 159 [1+] 89 [2+] 59 [3+] 22 [4+] 20 [5+] 0
Hits/KSLOC@level+ = [0+] 81.4967 [1+] 45.6176 [2+] 30.2409 [3+] 11.2763 [4+] 10.2512 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.