Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/zathura-0.4.7/tests/test_document.c
Examining data/zathura-0.4.7/tests/test_sandbox.c
Examining data/zathura-0.4.7/tests/test_session.c
Examining data/zathura-0.4.7/tests/test_types.c
Examining data/zathura-0.4.7/tests/test_utils.c
Examining data/zathura-0.4.7/tests/tests.c
Examining data/zathura-0.4.7/tests/tests.h
Examining data/zathura-0.4.7/zathura/adjustment.c
Examining data/zathura-0.4.7/zathura/adjustment.h
Examining data/zathura-0.4.7/zathura/bookmarks.c
Examining data/zathura-0.4.7/zathura/bookmarks.h
Examining data/zathura-0.4.7/zathura/callbacks.c
Examining data/zathura-0.4.7/zathura/callbacks.h
Examining data/zathura-0.4.7/zathura/checked-integer-arithmetic.c
Examining data/zathura-0.4.7/zathura/checked-integer-arithmetic.h
Examining data/zathura-0.4.7/zathura/commands.c
Examining data/zathura-0.4.7/zathura/commands.h
Examining data/zathura-0.4.7/zathura/completion.c
Examining data/zathura-0.4.7/zathura/completion.h
Examining data/zathura-0.4.7/zathura/config.c
Examining data/zathura-0.4.7/zathura/config.h
Examining data/zathura-0.4.7/zathura/content-type.c
Examining data/zathura-0.4.7/zathura/content-type.h
Examining data/zathura-0.4.7/zathura/database-plain.c
Examining data/zathura-0.4.7/zathura/database-plain.h
Examining data/zathura-0.4.7/zathura/database-sqlite.c
Examining data/zathura-0.4.7/zathura/database-sqlite.h
Examining data/zathura-0.4.7/zathura/database.c
Examining data/zathura-0.4.7/zathura/database.h
Examining data/zathura-0.4.7/zathura/dbus-interface.c
Examining data/zathura-0.4.7/zathura/dbus-interface.h
Examining data/zathura-0.4.7/zathura/document.c
Examining data/zathura-0.4.7/zathura/document.h
Examining data/zathura-0.4.7/zathura/file-monitor-glib.c
Examining data/zathura-0.4.7/zathura/file-monitor-glib.h
Examining data/zathura-0.4.7/zathura/file-monitor-noop.c
Examining data/zathura-0.4.7/zathura/file-monitor-noop.h
Examining data/zathura-0.4.7/zathura/file-monitor-signal.c
Examining data/zathura-0.4.7/zathura/file-monitor-signal.h
Examining data/zathura-0.4.7/zathura/file-monitor.c
Examining data/zathura-0.4.7/zathura/file-monitor.h
Examining data/zathura-0.4.7/zathura/internal.h
Examining data/zathura-0.4.7/zathura/jumplist.c
Examining data/zathura-0.4.7/zathura/jumplist.h
Examining data/zathura-0.4.7/zathura/links.c
Examining data/zathura-0.4.7/zathura/links.h
Examining data/zathura-0.4.7/zathura/macros.h
Examining data/zathura-0.4.7/zathura/main.c
Examining data/zathura-0.4.7/zathura/marks.c
Examining data/zathura-0.4.7/zathura/marks.h
Examining data/zathura-0.4.7/zathura/page-widget.c
Examining data/zathura-0.4.7/zathura/page-widget.h
Examining data/zathura-0.4.7/zathura/page.c
Examining data/zathura-0.4.7/zathura/page.h
Examining data/zathura-0.4.7/zathura/plugin-api.h
Examining data/zathura-0.4.7/zathura/plugin.c
Examining data/zathura-0.4.7/zathura/plugin.h
Examining data/zathura-0.4.7/zathura/print.c
Examining data/zathura-0.4.7/zathura/print.h
Examining data/zathura-0.4.7/zathura/render.c
Examining data/zathura-0.4.7/zathura/render.h
Examining data/zathura-0.4.7/zathura/seccomp-filters.c
Examining data/zathura-0.4.7/zathura/seccomp-filters.h
Examining data/zathura-0.4.7/zathura/shortcuts.c
Examining data/zathura-0.4.7/zathura/shortcuts.h
Examining data/zathura-0.4.7/zathura/synctex.c
Examining data/zathura-0.4.7/zathura/synctex.h
Examining data/zathura-0.4.7/zathura/types.c
Examining data/zathura-0.4.7/zathura/types.h
Examining data/zathura-0.4.7/zathura/utils.c
Examining data/zathura-0.4.7/zathura/utils.h
Examining data/zathura-0.4.7/zathura/zathura.c
Examining data/zathura-0.4.7/zathura/zathura.h
FINAL RESULTS:
data/zathura-0.4.7/zathura/seccomp-filters.c:199:14: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
ALLOW_RULE(readlink);
data/zathura-0.4.7/zathura/seccomp-filters.c:97:13: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
DENY_RULE(syslog);
data/zathura-0.4.7/zathura/seccomp-filters.c:141:14: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
ALLOW_RULE(access);
data/zathura-0.4.7/zathura/seccomp-filters.c:55:13: [3] (misc) chroot:
chroot can be very helpful, but is hard to use correctly (CWE-250, CWE-22).
Make sure the program immediately chdir("/"), closes file descriptors, and
drops root privileges, and that all necessary files (and no more!) are in
the new root.
DENY_RULE(chroot);
data/zathura-0.4.7/zathura/callbacks.c:393:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
index = atoi(input);
data/zathura-0.4.7/zathura/callbacks.c:638:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
page_set(zathura, atoi(input) - 1);
data/zathura-0.4.7/zathura/commands.c:469:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int page_id = atoi(input);
data/zathura-0.4.7/zathura/commands.c:480:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int image_id = atoi(input + 1);
data/zathura-0.4.7/zathura/commands.c:580:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
page_offset = atoi(value);
data/zathura-0.4.7/zathura/content-type.c:182:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* f = fopen(path, "rb");
data/zathura-0.4.7/zathura/database-plain.c:113:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* file = fopen(path, "w");
data/zathura-0.4.7/zathura/database-plain.c:134:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* file = fopen(path, "r+");
data/zathura-0.4.7/zathura/database-plain.c:207:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open(file, O_RDWR | O_TRUNC);
data/zathura-0.4.7/zathura/database-plain.c:521:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
bookmark->page = atoi(val_list[0]);
data/zathura-0.4.7/zathura/database-plain.c:611:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[G_ASCII_DTOSTR_BUF_SIZE] = { '\0' };
data/zathura-0.4.7/zathura/database-plain.c:740:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* file = fopen(priv->input_history_path, "r");
data/zathura-0.4.7/zathura/database-plain.c:774:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* file = fopen(priv->input_history_path, "r+");
data/zathura-0.4.7/zathura/database-sqlite.c:351:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char transaction[sizeof(tx_begin) + sizeof(SQL_FILEINFO_INIT) + sizeof(tx_end) - 2] = { '\0' };
data/zathura-0.4.7/zathura/document.c:70:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* f = fopen(path, "rb");
data/zathura-0.4.7/zathura/render.c:358:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&priv->recolor.light, light, sizeof(GdkRGBA));
data/zathura-0.4.7/zathura/render.c:361:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&priv->recolor.dark, dark, sizeof(GdkRGBA));
data/zathura-0.4.7/zathura/render.c:393:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(light, &priv->recolor.light, sizeof(GdkRGBA));
data/zathura-0.4.7/zathura/render.c:396:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dark, &priv->recolor.dark, sizeof(GdkRGBA));
data/zathura-0.4.7/zathura/seccomp-filters.c:244:37: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ADD_RULE("allow", SCMP_ACT_ALLOW, open, 1, SCMP_CMP(1, SCMP_CMP_MASKED_EQ, O_WRONLY | O_RDWR, 0));
data/zathura-0.4.7/zathura/seccomp-filters.c:245:45: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ADD_RULE("errno", SCMP_ACT_ERRNO(EACCES), open, 1, SCMP_CMP(1, SCMP_CMP_MASKED_EQ, O_WRONLY, O_WRONLY));
data/zathura-0.4.7/zathura/seccomp-filters.c:246:45: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ADD_RULE("errno", SCMP_ACT_ERRNO(EACCES), open, 1, SCMP_CMP(1, SCMP_CMP_MASKED_EQ, O_RDWR, O_RDWR));
data/zathura-0.4.7/zathura/utils.c:281:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
first_page_column = atoi(settings[index]);
data/zathura-0.4.7/zathura/utils.c:283:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
first_page_column = atoi(settings[settings_size - 1]);
data/zathura-0.4.7/zathura/zathura.c:772:19: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
g_file_delete(tmpfile, NULL, NULL);
data/zathura-0.4.7/zathura/zathura.c:773:20: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
g_object_unref(tmpfile);
data/zathura-0.4.7/zathura/zathura.c:777:32: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
char* file = g_file_get_path(tmpfile);
data/zathura-0.4.7/zathura/zathura.c:778:18: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
g_object_unref(tmpfile);
data/zathura-0.4.7/zathura/zathura.c:800:37: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
gboolean rc = g_file_copy(source, tmpfile, G_FILE_COPY_OVERWRITE, NULL, NULL,
data/zathura-0.4.7/zathura/zathura.c:808:20: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
g_object_unref(tmpfile);
data/zathura-0.4.7/zathura/zathura.c:812:26: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
file = g_file_get_path(tmpfile);
data/zathura-0.4.7/zathura/zathura.c:814:18: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
g_object_unref(tmpfile);
data/zathura-0.4.7/zathura/callbacks.c:387:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (input == NULL || strlen(input) == 0) {
data/zathura-0.4.7/zathura/callbacks.c:511:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (input == NULL || strlen(input) == 0) {
data/zathura-0.4.7/zathura/callbacks.c:630:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t size = strlen(input);
data/zathura-0.4.7/zathura/commands.c:115:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(string->str) > 0) {
data/zathura-0.4.7/zathura/commands.c:116:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_string_erase(string, strlen(string->str) - 1, 1);
data/zathura-0.4.7/zathura/commands.c:364:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (zathura->document == NULL || strlen(input) == 0) {
data/zathura-0.4.7/zathura/commands.c:459:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(file_identifier, "attachment-", strlen("attachment-")) == 0) {
data/zathura-0.4.7/zathura/commands.c:460:79: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (zathura_document_attachment_save(zathura->document, file_identifier + strlen("attachment-"), export_path) == false) {
data/zathura-0.4.7/zathura/commands.c:466:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (strncmp(file_identifier, "image-p", strlen("image-p")) == 0 && strlen(file_identifier) >= 10) {
data/zathura-0.4.7/zathura/commands.c:466:77: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (strncmp(file_identifier, "image-p", strlen("image-p")) == 0 && strlen(file_identifier) >= 10) {
data/zathura-0.4.7/zathura/commands.c:468:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const char* input = file_identifier + strlen("image-p");
data/zathura-0.4.7/zathura/completion.c:66:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t e_length = strlen(e_name);
data/zathura-0.4.7/zathura/completion.c:157:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(path) == 0 || path[0] != '/') {
data/zathura-0.4.7/zathura/completion.c:174:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bool is_dir = (path[strlen(path) - 1] == '/') ? true : false;
data/zathura-0.4.7/zathura/completion.c:187:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t current_file_length = strlen(current_file);
data/zathura-0.4.7/zathura/completion.c:284:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t input_length = strlen(input);
data/zathura-0.4.7/zathura/completion.c:286:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (input_length <= strlen(bookmark->id) && !strncmp(input, bookmark->id, input_length)) {
data/zathura-0.4.7/zathura/completion.c:336:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t input_length = strlen(input);
data/zathura-0.4.7/zathura/completion.c:342:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (input_length <= strlen(attachment) && !strncmp(input, attachment, input_length)) {
data/zathura-0.4.7/zathura/database-plain.c:96:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return g_base64_encode((const guchar*) file, strlen(file));
data/zathura-0.4.7/zathura/database-plain.c:159:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t contentlen = strlen(content);
data/zathura-0.4.7/zathura/database-plain.c:213:68: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (file_lock_set(fd, FILE_LOCK_READ) != 0 || write(fd, content, strlen(content)) == 0) {
data/zathura-0.4.7/zathura/database-plain.c:224:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_return_val_if_fail(path != NULL && strlen(path) != 0, NULL);
data/zathura-0.4.7/zathura/database-plain.c:756:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(tmp[i]) == 0 || strchr(":/?", tmp[i][0]) == NULL) {
data/zathura-0.4.7/zathura/database-plain.c:798:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(tmp[i]) == 0 || strchr(":/?", tmp[i][0]) == NULL || strcmp(tmp[i], input) == 0) {
data/zathura-0.4.7/zathura/database-plain.c:851:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t basepath_len = basepath != NULL ? strlen(basepath) : 0;
data/zathura-0.4.7/zathura/database-sqlite.c:42:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_return_val_if_fail(path != NULL && strlen(path) != 0, NULL);
data/zathura-0.4.7/zathura/dbus-interface.c:222:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(password) > 0 ? password : NULL,
data/zathura-0.4.7/zathura/document.c:82:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
size_t read;
data/zathura-0.4.7/zathura/document.c:84:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
g_checksum_update(checksum, buf, read);
data/zathura-0.4.7/zathura/marks.c:127:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (key_string == NULL || strlen(key_string) != 1) {
data/zathura-0.4.7/zathura/marks.c:163:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (unsigned int i = 0; i < strlen(key_string); i++) {
data/zathura-0.4.7/zathura/seccomp-filters.c:198:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ALLOW_RULE(read);
data/zathura-0.4.7/zathura/zathura.c:922:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t file_path_len = file_path ? strlen(file_path) : 0;
data/zathura-0.4.7/zathura/zathura.c:926:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t home_len = home ? strlen(home) : 0;
ANALYSIS SUMMARY:
Hits = 71
Lines analyzed = 19957 in approximately 0.47 seconds (42023 lines/second)
Physical Source Lines of Code (SLOC) = 13668
Hits@level = [0] 7 [1] 35 [2] 32 [3] 1 [4] 2 [5] 1
Hits@level+ = [0+] 78 [1+] 71 [2+] 36 [3+] 4 [4+] 3 [5+] 1
Hits/KSLOC@level+ = [0+] 5.70676 [1+] 5.19462 [2+] 2.63389 [3+] 0.292654 [4+] 0.219491 [5+] 0.0731636
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.