Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/zdbsp-1.19+20181027+dfsg.1/Unused/rejectbuilder.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/Unused/rejectbuilder.h
Examining data/zdbsp-1.19+20181027+dfsg.1/Unused/vis.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/Unused/visflow.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/blockmapbuilder.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/blockmapbuilder.h
Examining data/zdbsp-1.19+20181027+dfsg.1/doomdata.h
Examining data/zdbsp-1.19+20181027+dfsg.1/getopt.c
Examining data/zdbsp-1.19+20181027+dfsg.1/getopt.h
Examining data/zdbsp-1.19+20181027+dfsg.1/getopt1.c
Examining data/zdbsp-1.19+20181027+dfsg.1/main.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild.h
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild_classify_nosse2.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild_classify_sse1.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild_classify_sse2.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild_classify_sse2_vect.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild_events.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild_extract.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild_gl.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/nodebuild_utility.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/processor.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/processor.h
Examining data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/resource.h
Examining data/zdbsp-1.19+20181027+dfsg.1/sc_man.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/sc_man.h
Examining data/zdbsp-1.19+20181027+dfsg.1/tarray.h
Examining data/zdbsp-1.19+20181027+dfsg.1/templates.h
Examining data/zdbsp-1.19+20181027+dfsg.1/view.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/wad.cpp
Examining data/zdbsp-1.19+20181027+dfsg.1/wad.h
Examining data/zdbsp-1.19+20181027+dfsg.1/workdata.h
Examining data/zdbsp-1.19+20181027+dfsg.1/xs_Float.h
Examining data/zdbsp-1.19+20181027+dfsg.1/zdbsp.h
FINAL RESULTS:
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:34:17: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
if (!NoTiming) printf (l, double(e.QuadPart - s.QuadPart) / double(f.QuadPart));
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:44:17: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
if (!NoTiming) printf (l, double(e - s) / CLOCKS_PER_SEC);
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:202:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (out, OutName);
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:446:2: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf (
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:711:2: [4] (format) vprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vprintf (format, marker);
data/zdbsp-1.19+20181027+dfsg.1/nodebuild.cpp:33:16: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define Printf printf
data/zdbsp-1.19+20181027+dfsg.1/nodebuild_gl.cpp:24:16: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define Printf printf
data/zdbsp-1.19+20181027+dfsg.1/nodebuild_utility.cpp:38:16: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define Printf printf
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:63:21: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
return p != NULL? strcpy(Alloc(strlen(p)+1) , p) : NULL;
data/zdbsp-1.19+20181027+dfsg.1/sc_man.cpp:694:2: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
vsprintf (composed, message, arglist);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:219:7: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *getenv ();
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:409:21: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
posixly_correct = getenv ("POSIXLY_CORRECT");
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:981:1: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt (argc, argv, optstring)
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:1011:11: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt (argc, argv, "abc:d:0123456789");
data/zdbsp-1.19+20181027+dfsg.1/getopt.h:103:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt (int argc, char *const *argv, const char *shortopts);
data/zdbsp-1.19+20181027+dfsg.1/getopt.h:105:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt ();
data/zdbsp-1.19+20181027+dfsg.1/getopt.h:108:12: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt_long (int argc, char *const *argv, const char *shortopts,
data/zdbsp-1.19+20181027+dfsg.1/getopt.h:120:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt ();
data/zdbsp-1.19+20181027+dfsg.1/getopt.h:121:12: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt_long ();
data/zdbsp-1.19+20181027+dfsg.1/getopt1.c:68:1: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt_long (argc, argv, options, long_options, opt_index)
data/zdbsp-1.19+20181027+dfsg.1/getopt1.c:124:11: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long (argc, argv, "abc:d:0123456789",
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:313:15: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((ch = getopt_long (argc, argv, short_opts, long_opts, NULL)) != EOF)
data/zdbsp-1.19+20181027+dfsg.1/Unused/vis.cpp:196:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (visBytes + leafnum*leafbytes, uncompressed, leafbytes);
data/zdbsp-1.19+20181027+dfsg.1/Unused/visflow.cpp:559:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(might, prevmight, portalbytes);
data/zdbsp-1.19+20181027+dfsg.1/Unused/visflow.cpp:697:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(might, prevmight, portalbytes);
data/zdbsp-1.19+20181027+dfsg.1/Unused/visflow.cpp:1079:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&in, &p->winding, sizeof(FWinding));
data/zdbsp-1.19+20181027+dfsg.1/Unused/visflow.cpp:1084:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&in, &out, sizeof(FWinding));
data/zdbsp-1.19+20181027+dfsg.1/blockmapbuilder.cpp:78:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *f = fopen ("blockmap.lmp", "rb");
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:36:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char toptexture[8];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:37:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bottomtexture[8];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:38:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char midtexture[8];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:47:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char toptexture[8];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:48:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bottomtexture[8];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:49:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char midtexture[8];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:72:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char args[5];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:92:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char floorpic[8];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:93:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ceilingpic[8];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:203:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char args[5];
data/zdbsp-1.19+20181027+dfsg.1/doomdata.h:217:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char args[5];
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:337:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (new_str, __getopt_nonoption_flags, nonoption_flags_max_len);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:449:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (__getopt_nonoption_flags, orig_str, len);
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:216:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat (out, ".x");
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:354:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
MaxSegs = atoi (optarg);
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:361:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
SplitCost = atoi (optarg);
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:368:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
AAPreference = atoi (optarg);
data/zdbsp-1.19+20181027+dfsg.1/nodebuild_extract.cpp:76:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (outSegs, &segs[0], segCount*sizeof(MapSegGLEx));
data/zdbsp-1.19+20181027+dfsg.1/nodebuild_extract.cpp:415:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (outSegs, &segs[0], segCount*sizeof(MapSegEx));
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:239:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(Level.Sides[i].toptexture, Sides[i].toptexture, 8);
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:240:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(Level.Sides[i].bottomtexture, Sides[i].bottomtexture, 8);
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:241:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(Level.Sides[i].midtexture, Sides[i].midtexture, 8);
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:554:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *f = fopen ("blockmap.lmp", "wb");
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:662:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (Level.Blockmap, blocks, Level.BlockmapSize*sizeof(WORD));
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:816:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char glname[9];
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:1011:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(Sides[i].toptexture, Level.Sides[i].toptexture, 8);
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:1012:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(Sides[i].bottomtexture, Level.Sides[i].bottomtexture, 8);
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:1013:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(Sides[i].midtexture, Level.Sides[i].midtexture, 8);
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:1199:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *f = fopen ("blockmap.lm2", "wb");
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:384:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(Level.Vertices, &Vertices[0], Vertices.Size() * sizeof(WideVertex));
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:426:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[20];
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:430:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%d;\n", value);
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:445:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[32];
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:446:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
int len = sprintf(buffer, " // %d", num);
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:465:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[32];
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:466:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
int len = sprintf(buffer, " // %d", num);
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:489:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[32];
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:490:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
int len = sprintf(buffer, " // %d", num);
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:510:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[32];
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:511:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
int len = sprintf(buffer, " // %d", num);
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:530:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[32];
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:531:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
int len = sprintf(buffer, " // %d", num);
data/zdbsp-1.19+20181027+dfsg.1/sc_man.cpp:76:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char StringBuffer[MAX_STRING_SIZE];
data/zdbsp-1.19+20181027+dfsg.1/sc_man.cpp:686:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char composed[2048];
data/zdbsp-1.19+20181027+dfsg.1/view.cpp:199:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char foo[16];
data/zdbsp-1.19+20181027+dfsg.1/wad.cpp:22:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char MapLumpNames[12][9] =
data/zdbsp-1.19+20181027+dfsg.1/wad.cpp:54:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char GLLumpNames[5][9] =
data/zdbsp-1.19+20181027+dfsg.1/wad.cpp:66:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
File = fopen (filename, "rb");
data/zdbsp-1.19+20181027+dfsg.1/wad.cpp:337:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char name[9];
data/zdbsp-1.19+20181027+dfsg.1/wad.cpp:346:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
File = fopen (filename, "wb");
data/zdbsp-1.19+20181027+dfsg.1/wad.h:16:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Magic[4];
data/zdbsp-1.19+20181027+dfsg.1/wad.h:25:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Name[8];
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:242:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
extern int strlen (const char *);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:440:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = nonoption_flags_max_len = strlen (orig_str);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:664:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
== (unsigned int) strlen (p->name))
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:688:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:724:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:740:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:745:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:856:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((unsigned int) (nameend - nextchar) == strlen (p->name))
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:879:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:899:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:913:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/zdbsp-1.19+20181027+dfsg.1/getopt.c:917:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/zdbsp-1.19+20181027+dfsg.1/main.cpp:195:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *out = new char[strlen(OutName)+3], *dot;
data/zdbsp-1.19+20181027+dfsg.1/processor.cpp:821:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (glname+3, Wad.LumpName (Lump), 5);
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:63:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return p != NULL? strcpy(Alloc(strlen(p)+1) , p) : NULL;
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:411:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
out.AddToLump(props[i].key, (int)strlen(props[i].key));
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:413:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
out.AddToLump(props[i].value, (int)strlen(props[i].value));
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:428:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
out.AddToLump(key, (int)strlen(key));
data/zdbsp-1.19+20181027+dfsg.1/processor_udmf.cpp:431:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
out.AddToLump(buffer, (int)strlen(buffer));
data/zdbsp-1.19+20181027+dfsg.1/wad.cpp:338:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (name, Lumps[lump].Name, 8);
data/zdbsp-1.19+20181027+dfsg.1/wad.cpp:398:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (lump.Name, name, 8);
data/zdbsp-1.19+20181027+dfsg.1/wad.cpp:408:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (lump.Name, name, 8);
ANALYSIS SUMMARY:
Hits = 102
Lines analyzed = 15069 in approximately 0.33 seconds (45581 lines/second)
Physical Source Lines of Code (SLOC) = 11161
Hits@level = [0] 119 [1] 22 [2] 58 [3] 12 [4] 10 [5] 0
Hits@level+ = [0+] 221 [1+] 102 [2+] 80 [3+] 22 [4+] 10 [5+] 0
Hits/KSLOC@level+ = [0+] 19.8011 [1+] 9.13897 [2+] 7.16782 [3+] 1.97115 [4+] 0.895977 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.