Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/zita-njbridge-0.4.4/source/pxthread.h
Examining data/zita-njbridge-0.4.4/source/jackrx.cc
Examining data/zita-njbridge-0.4.4/source/netrx.h
Examining data/zita-njbridge-0.4.4/source/netrx.cc
Examining data/zita-njbridge-0.4.4/source/nettx.cc
Examining data/zita-njbridge-0.4.4/source/zsockets.h
Examining data/zita-njbridge-0.4.4/source/synctest.cc
Examining data/zita-njbridge-0.4.4/source/pxthread.cc
Examining data/zita-njbridge-0.4.4/source/lfqueue.cc
Examining data/zita-njbridge-0.4.4/source/jackrx.h
Examining data/zita-njbridge-0.4.4/source/zita-j2n.cc
Examining data/zita-njbridge-0.4.4/source/netdata.h
Examining data/zita-njbridge-0.4.4/source/zsockets.cc
Examining data/zita-njbridge-0.4.4/source/timers.h
Examining data/zita-njbridge-0.4.4/source/syncrx.h
Examining data/zita-njbridge-0.4.4/source/nettx.h
Examining data/zita-njbridge-0.4.4/source/zita-n2j.cc
Examining data/zita-njbridge-0.4.4/source/netdata.cc
Examining data/zita-njbridge-0.4.4/source/syncrx.cc
Examining data/zita-njbridge-0.4.4/source/jacktx.cc
Examining data/zita-njbridge-0.4.4/source/jacktx.h
Examining data/zita-njbridge-0.4.4/source/lfqueue.h
FINAL RESULTS:
data/zita-njbridge-0.4.4/source/zsockets.cc:65:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (U->sun_path, address);
data/zita-njbridge-0.4.4/source/zsockets.cc:116:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (address, U->sun_path);
data/zita-njbridge-0.4.4/source/zita-j2n.cc:112:17: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((k = getopt_long (ac, av, "", options, 0)) != -1)
data/zita-njbridge-0.4.4/source/zita-n2j.cc:112:17: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((k = getopt_long (ac, av, "", options, 0)) != -1)
data/zita-njbridge-0.4.4/source/jackrx.cc:49:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s [16];
data/zita-njbridge-0.4.4/source/jackrx.cc:82:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (s, "out_%d", clist [i] + 1);
data/zita-njbridge-0.4.4/source/jacktx.cc:51:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s [64];
data/zita-njbridge-0.4.4/source/jacktx.cc:83:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (s, "in_%d", i + 1);
data/zita-njbridge-0.4.4/source/syncrx.cc:59:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char d [32];
data/zita-njbridge-0.4.4/source/synctest.cc:38:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char data [32];
data/zita-njbridge-0.4.4/source/synctest.cc:48:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pn = atoi (av [2]);
data/zita-njbridge-0.4.4/source/synctest.cc:63:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
del = atoi (av [3]);
data/zita-njbridge-0.4.4/source/synctest.cc:67:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (data + 0, "/time");
data/zita-njbridge-0.4.4/source/synctest.cc:68:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (data + 8, ",ii");
data/zita-njbridge-0.4.4/source/zita-j2n.cc:149:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port_arg = atoi (av [optind++]);
data/zita-njbridge-0.4.4/source/zita-n2j.cc:146:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port_arg = atoi (av [optind++]);
data/zita-njbridge-0.4.4/source/zita-n2j.cc:273:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s [256];
data/zita-njbridge-0.4.4/source/zsockets.cc:82:14: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
if (len) memcpy (_data, (char *)(A->ai_addr), len);
data/zita-njbridge-0.4.4/source/zsockets.cc:409:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&mcreq.ipv6mr_multiaddr, &(A6->sin6_addr), sizeof(struct in6_addr));
data/zita-njbridge-0.4.4/source/zsockets.h:50:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char _data [sizeof (struct sockaddr_storage)];
data/zita-njbridge-0.4.4/source/pxthread.h:182:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
#define usleep(t) Sleep ((t) / 1000);
data/zita-njbridge-0.4.4/source/syncrx.cc:42:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(100000);
data/zita-njbridge-0.4.4/source/synctest.cc:72:2: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (250000);
data/zita-njbridge-0.4.4/source/zita-j2n.cc:240:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (100000);
data/zita-njbridge-0.4.4/source/zita-j2n.cc:257:2: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (500000);
data/zita-njbridge-0.4.4/source/zita-j2n.cc:263:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (100000);
data/zita-njbridge-0.4.4/source/zita-n2j.cc:325:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (100000);
data/zita-njbridge-0.4.4/source/zita-n2j.cc:386:44: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
while (! (stop || checkstatus ())) usleep (250000);
data/zita-njbridge-0.4.4/source/zita-n2j.cc:390:2: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (100000);
data/zita-njbridge-0.4.4/source/zsockets.cc:63:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((int) strlen (address) > len - 1) return -1;
data/zita-njbridge-0.4.4/source/zsockets.cc:352:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (ifr.ifr_name, iface, 16);
data/zita-njbridge-0.4.4/source/zsockets.cc:436:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (ifreq.ifr_name, iface, 16);
data/zita-njbridge-0.4.4/source/zsockets.cc:513:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
n = read (fd, (char *) data + k, size - k);
ANALYSIS SUMMARY:
Hits = 33
Lines analyzed = 4334 in approximately 0.11 seconds (39195 lines/second)
Physical Source Lines of Code (SLOC) = 2962
Hits@level = [0] 74 [1] 13 [2] 16 [3] 2 [4] 2 [5] 0
Hits@level+ = [0+] 107 [1+] 33 [2+] 20 [3+] 4 [4+] 2 [5+] 0
Hits/KSLOC@level+ = [0+] 36.1242 [1+] 11.1411 [2+] 6.75219 [3+] 1.35044 [4+] 0.675219 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.