In /usr/bin/nmudiff line 17: PROGNAME=`basename $0` ^-----------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^-- SC2086: Double quote to prevent globbing and word splitting. Did you mean: PROGNAME=$(basename "$0") In /usr/bin/nmudiff line 22: "Usage: $PROGNAME ^-- SC1078: Did you forget to close this double quoted string? In /usr/bin/nmudiff line 39: to a placeholder value of "XX". If DELAY is 0 then ^-- SC1079: This is actually an end quote, but due to next char it looks suspect. ^-- SC2140: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"? In /usr/bin/nmudiff line 68: DEFAULT_NMUDIFF_DELAY="XX" ^-------------------^ SC2034: DEFAULT_NMUDIFF_DELAY appears unused. Verify use (or export if used externally). In /usr/bin/nmudiff line 69: DEFAULT_NMUDIFF_MUTT="yes" ^------------------^ SC2034: DEFAULT_NMUDIFF_MUTT appears unused. Verify use (or export if used externally). In /usr/bin/nmudiff line 70: DEFAULT_NMUDIFF_NEWREPORT="maybe" ^-----------------------^ SC2034: DEFAULT_NMUDIFF_NEWREPORT appears unused. Verify use (or export if used externally). In /usr/bin/nmudiff line 71: DEFAULT_BTS_SENDMAIL_COMMAND="/usr/sbin/sendmail" ^--------------------------^ SC2034: DEFAULT_BTS_SENDMAIL_COMMAND appears unused. Verify use (or export if used externally). In /usr/bin/nmudiff line 72: DEFAULT_NMUDIFF_PENDING=" pending" ^---------------------^ SC2034: DEFAULT_NMUDIFF_PENDING appears unused. Verify use (or export if used externally). In /usr/bin/nmudiff line 73: DEFAULT_MUTT_PRG="mutt" ^--------------^ SC2034: DEFAULT_MUTT_PRG appears unused. Verify use (or export if used externally). In /usr/bin/nmudiff line 80: if [ "$1" = "--no-conf" -o "$1" = "--noconf" ]; then ^-- SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. In /usr/bin/nmudiff line 92: eval $( ^-- SC2046: Quote this to prevent word splitting. In /usr/bin/nmudiff line 100: [ -r $file ] && . $file ^---^ SC1090: Can't follow non-constant source. Use a directive to specify location. In /usr/bin/nmudiff line 103: set | egrep '^(NMUDIFF|BTS|DEVSCRIPTS)_') ^---^ SC2196: egrep is non-standard and deprecated. Use grep -E instead. In /usr/bin/nmudiff line 162: eval set -- $TEMP ^---^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: eval set -- "$TEMP" In /usr/bin/nmudiff line 260: : ${FROMNAME:="$DEBFULLNAME"} ^-------------------------^ SC2223: This default assignment may cause DoS due to globbing. Quote it. In /usr/bin/nmudiff line 261: : ${FROMNAME:="$NAME"} ^------------------^ SC2223: This default assignment may cause DoS due to globbing. Quote it. In /usr/bin/nmudiff line 263: : ${FROM:="$DEBEMAIL"} ^------------------^ SC2223: This default assignment may cause DoS due to globbing. Quote it. In /usr/bin/nmudiff line 264: : ${FROM:="$EMAIL"} ^---------------^ SC2223: This default assignment may cause DoS due to globbing. Quote it. In /usr/bin/nmudiff line 304: if $(expr match "$CLOSES" ".* " > /dev/null); then ^-- SC2091: Remove surrounding $() to avoid executing output. ^--^ SC2003: expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. In /usr/bin/nmudiff line 318: VERSION_NO_EPOCH=$(echo "$VERSION" | sed "s/^[0-9]\+://") ^-- SC2001: See if you can use ${variable//search/replace} instead. In /usr/bin/nmudiff line 319: OLDVERSION_NO_EPOCH=$(echo "$OLDVERSION" | sed "s/^[0-9]\+://") ^-- SC2001: See if you can use ${variable//search/replace} instead. In /usr/bin/nmudiff line 321: if [ ! -r ../${SOURCE}_${OLDVERSION_NO_EPOCH}.dsc ]; then ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^--------------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if [ ! -r ../"${SOURCE}"_"${OLDVERSION_NO_EPOCH}".dsc ]; then In /usr/bin/nmudiff line 325: if [ ! -r ../${SOURCE}_${VERSION_NO_EPOCH}.dsc ]; then ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if [ ! -r ../"${SOURCE}"_"${VERSION_NO_EPOCH}".dsc ]; then In /usr/bin/nmudiff line 331: debdiff ../${SOURCE}_${OLDVERSION_NO_EPOCH}.dsc \ ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^--------------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: debdiff ../"${SOURCE}"_"${OLDVERSION_NO_EPOCH}".dsc \ In /usr/bin/nmudiff line 332: ../${SOURCE}_${VERSION_NO_EPOCH}.dsc \ ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: ../"${SOURCE}"_"${VERSION_NO_EPOCH}".dsc \ In /usr/bin/nmudiff line 333: > ../${SOURCE}-${VERSION_NO_EPOCH}-nmu.diff || ret=$? ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: > ../"${SOURCE}"-"${VERSION_NO_EPOCH}"-nmu.diff || ret=$? In /usr/bin/nmudiff line 336: rm -f ../${SOURCE}-${VERSION_NO_EPOCH}-nmu.diff ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: rm -f ../"${SOURCE}"-"${VERSION_NO_EPOCH}"-nmu.diff In /usr/bin/nmudiff line 357: if [ "`bts select bugs:$b tag:patch`" != "$b" ]; then ^----------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^-- SC2086: Double quote to prevent globbing and word splitting. Did you mean: if [ "$(bts select bugs:"$b" tag:patch)" != "$b" ]; then In /usr/bin/nmudiff line 361: if [ "$NMUDIFF_DELAY" != "0" ] && [ "`bts select bugs:$b tag:pending`" != "$b" ] && [ $NMUDIFF_PENDING ]; then ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^-- SC2086: Double quote to prevent globbing and word splitting. ^--------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if [ "$NMUDIFF_DELAY" != "0" ] && [ "$(bts select bugs:"$b" tag:pending)" != "$b" ] && [ "$NMUDIFF_PENDING" ]; then In /usr/bin/nmudiff line 372: TMPNAM="$(tempfile)" ^------^ SC2186: tempfile is deprecated. Use mktemp instead. In /usr/bin/nmudiff line 410: Date: `date -R` ^-------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: Date: $(date -R) In /usr/bin/nmudiff line 420: cat ../${SOURCE}-${VERSION_NO_EPOCH}-nmu.diff >> "$TMPNAM" ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: cat ../"${SOURCE}"-"${VERSION_NO_EPOCH}"-nmu.diff >> "$TMPNAM" In /usr/bin/nmudiff line 422: if [ $? -ne 0 ]; then ^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. In /usr/bin/nmudiff line 424: rm -f ../${SOURCE}-${VERSION_NO_EPOCH}-nmu.diff "$TMPNAM" ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: rm -f ../"${SOURCE}"-"${VERSION_NO_EPOCH}"-nmu.diff "$TMPNAM" In /usr/bin/nmudiff line 430: read response ^--^ SC2162: read without -r will mangle backslashes. In /usr/bin/nmudiff line 434: rm -f ../${SOURCE}-${VERSION_NO_EPOCH}-nmu.diff "$TMPNAM" ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: rm -f ../"${SOURCE}"-"${VERSION_NO_EPOCH}"-nmu.diff "$TMPNAM" In /usr/bin/nmudiff line 459: -a ../${SOURCE}-${VERSION_NO_EPOCH}-nmu.diff $BCC_ADDRESS_MUTT \ ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. ^---------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: -a ../"${SOURCE}"-"${VERSION_NO_EPOCH}"-nmu.diff "$BCC_ADDRESS_MUTT" \ In /usr/bin/nmudiff line 460: -- $TO_ADDRESSES_MUTT ^----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: -- "$TO_ADDRESSES_MUTT" In /usr/bin/nmudiff line 464: rm -f ../${SOURCE}-${VERSION_NO_EPOCH}-nmu.diff "$TMPNAM" ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: rm -f ../"${SOURCE}"-"${VERSION_NO_EPOCH}"-nmu.diff "$TMPNAM" For more information: https://www.shellcheck.net/wiki/SC1078 -- Did you forget to close this doub... https://www.shellcheck.net/wiki/SC1090 -- Can't follow non-constant source.... https://www.shellcheck.net/wiki/SC2034 -- DEFAULT_BTS_SENDMAIL_COMMAND appe...