In /usr/bin/pkgkde-mark-private-symbols line 30: echo $@ ^-- SC2068: Double quote array expansions to avoid re-splitting elements. In /usr/bin/pkgkde-mark-private-symbols line 35: [ ! -n "${NODEBUG}" ] && echo $@ ^-- SC2236: Use -z instead of ! -n. ^-- SC2068: Double quote array expansions to avoid re-splitting elements. In /usr/bin/pkgkde-mark-private-symbols line 52: if [ ! -d ${PRIVATE_HEADERS} ] ^----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if [ ! -d "${PRIVATE_HEADERS}" ] In /usr/bin/pkgkde-mark-private-symbols line 57: if [ ! -n "${WRITERESULTS}" ] ^-- SC2236: Use -z instead of ! -n. In /usr/bin/pkgkde-mark-private-symbols line 60: for symbols_file in `ls debian/*.symbols` ^-------------------^ SC2045: Iterating over ls output is fragile. Use globs. ^-------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: for symbols_file in $(ls debian/*.symbols) In /usr/bin/pkgkde-mark-private-symbols line 62: cp $symbols_file $symbols_file.mps ^-----------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: cp "$symbols_file" "$symbols_file".mps In /usr/bin/pkgkde-mark-private-symbols line 68: for symbols_file in `ls debian/*.symbols` ^-------------------^ SC2045: Iterating over ls output is fragile. Use globs. ^-------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: for symbols_file in $(ls debian/*.symbols) In /usr/bin/pkgkde-mark-private-symbols line 70: if [ ! -n "${WRITERESULTS}" ] ^-- SC2236: Use -z instead of ! -n. In /usr/bin/pkgkde-mark-private-symbols line 72: sed -i 's/ 1$//g' $symbols_file.mps ^-----------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: sed -i 's/ 1$//g' "$symbols_file".mps In /usr/bin/pkgkde-mark-private-symbols line 74: sed -i 's/ 1$//g' $symbols_file ^-----------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: sed -i 's/ 1$//g' "$symbols_file" In /usr/bin/pkgkde-mark-private-symbols line 78: grep -rh class ${PRIVATE_HEADERS} | ^----------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: grep -rh class "${PRIVATE_HEADERS}" | In /usr/bin/pkgkde-mark-private-symbols line 80: while read class export classname rest ^--^ SC2162: read without -r will mangle backslashes. ^---^ SC2034: class appears unused. Verify use (or export if used externally). ^----^ SC2034: export appears unused. Verify use (or export if used externally). In /usr/bin/pkgkde-mark-private-symbols line 82: classname=$(echo $classname | sed 's/://') ^--------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: classname=$(echo "$classname" | sed 's/://') In /usr/bin/pkgkde-mark-private-symbols line 83: echo ${#classname}${classname} ^----------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo ${#classname}"${classname}" In /usr/bin/pkgkde-mark-private-symbols line 85: while read privateclass ^--^ SC2162: read without -r will mangle backslashes. In /usr/bin/pkgkde-mark-private-symbols line 87: debug Marking ${privateclass} as private ^-------------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: debug Marking "${privateclass}" as private In /usr/bin/pkgkde-mark-private-symbols line 96: if [ ! -n "${WRITERESULTS}" ] ^-- SC2236: Use -z instead of ! -n. In /usr/bin/pkgkde-mark-private-symbols line 99: for symbols_file in `ls debian/*.symbols` ^-------------------^ SC2045: Iterating over ls output is fragile. Use globs. ^-------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: for symbols_file in $(ls debian/*.symbols) In /usr/bin/pkgkde-mark-private-symbols line 101: diff -Nau $symbols_file $symbols_file.mps ^-----------^ SC2086: Double quote to prevent globbing and word splitting. ^-----------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: diff -Nau "$symbols_file" "$symbols_file".mps For more information: https://www.shellcheck.net/wiki/SC2045 -- Iterating over ls output is fragi... https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2034 -- class appears unused. Verify use ...